Created attachment 162607 [details] Port shar Required library for upcoming datadog agent port
@Uros, thanks for your submission :) On initial review, at least the following changes are needes: * Remove 'An' (indefinite article from COMMENT. Use the upstream (setup.py:description) instead. "Python client for Docker" * Rename to (dir, portname) to docker-py (as per PyPI name): https://pypi.python.org/pypi/docker-py For more info, see: https://wiki.freebsd.org/Python/PortsPolicy * RUN_DEPENDS no longer need to be added to TEST_DEPENDS. * Do the requirements in setup.py for RUN_DEPENDS use '>' or '>=' ? Please update them if they are >=. * Add 'python' as a secondary (virtual) CATEGORIES * Remove GH_PROJECT, wont be needed after PORTNAME change above. * Remove all commented out variables/targets, unless they are comments. If they are works in progress, don't commit them. * Rename regression-test: build target to 'do-test:'. This is a new target (as part of a new test framework) that was recently committed * Use the PYDISTUTILS_SETUP variable in your test invocation, as it is correctly wrapped in a setuptools import command. Please also confirm that this port passes QA (portlint -AC, poudriere testport)
Created attachment 162643 [details] Updated Port shar Here are required changes. I removed the test part as there are two dependencies that does not exists in ports atm. portlint and poudriere all good without issues.
In the mean time this was added to the ports tree in ports r438212.