Bug 204297 - [patch] Mk/bsd.port.mk: stage-qa target should depend on stage
Summary: [patch] Mk/bsd.port.mk: stage-qa target should depend on stage
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL: https://reviews.freebsd.org/D4082
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-11-04 23:14 UTC by Serhii (Sergey) Kozlov
Modified: 2015-11-09 21:18 UTC (History)
1 user (show)

See Also:

Attachments
The Patch (368 bytes, patch)
2015-11-04 23:14 UTC, Serhii (Sergey) Kozlov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Serhii (Sergey) Kozlov freebsd_committer freebsd_triage 2015-11-04 23:14:40 UTC 
Created attachment 162792 [details]
The Patch

"stage-qa" target should depend on "stage" like, for example, "check-plist" does.

If "stage" is not done, "stage-qa" have nothing to verify and reports "file not found" errors.

Checked on one of my ports: devel/staf

without the patch:
$ make clean stage-qa
===>  Cleaning for staf-3.4.23
====> Running Q/A tests (stage-qa)
cd: /usr/home/leeroyjenkins/prtwrk/staf/work/stage: No such file or directory
find: /usr/home/leeroyjenkins/prtwrk/staf/work/stage: No such file or directory
find: /usr/home/leeroyjenkins/prtwrk/staf/work/.PLIST.mktmp: No such file or directory
find: /usr/home/leeroyjenkins/prtwrk/staf/work/stage: No such file or directory
find: /usr/home/leeroyjenkins/prtwrk/staf/work/stage: No such file or directory
find: /usr/home/leeroyjenkins/prtwrk/staf/work/stage: No such file or directory

with the patch:
$ make clean stage-qa
===>  Cleaning for staf-3.4.23
... build omitted ...
===>  Staging for staf-3.4.23
===>   Generating temporary packing list
... staging omitted ...
====> Running Q/A tests (stage-qa)
Comment 1 Serhii (Sergey) Kozlov freebsd_committer freebsd_triage 2015-11-04 23:20:26 UTC 
Added review D4082
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2015-11-05 09:17:38 UTC 
You're missing DEVELOPER=yes from your make.conf.
Comment 3 Serhii (Sergey) Kozlov freebsd_committer freebsd_triage 2015-11-09 21:18:12 UTC 
Closed by commit rP401111: When !defined(DEVELOPER), stage-qa is not put in the stage pipeline. (authored by mat)

https://reviews.freebsd.org/rP401111