Created attachment 162886 [details] patch Changes: https://pip.pypa.io/en/stable/news/
Do regression/unit tests pass?
Testbuilds on 11-cur, 10.2a+i, 9.3a are fine. Ports that depend on it: devel/py-pbr (run_dep) devel/py-wheel (run_dep) net/py-tweepy (build_dep) sysutils/osquery (build_dep) www/py-frappe-bench (run_dep) Some needs to test those 8-} Any volunteers ?
How about unit tests? (see regression-test target)
Oh, a unicorn^Wregression test in this port ? Here are the results. What can we do with this ? 12 failed, 464 passed, 7 skipped, 1 pytest-warnings, 8 error in 1085.59 seconds
Running the same test on 7.0.3 gives: 12 failed, 452 passed, 7 skipped, 1 pytest-warnings, 8 error in 1072.23 seconds
(In reply to Kurt Jaeger from comment #5) Highly unpleasant, but at least the test failure delta is 0 between last_version and latest_version. Can you: * Update the test target to do-test * Make MDOCS conditionals options helpers They look like the only modernization things that are needed.
Created attachment 162896 [details] patch-v2
Changed the patch to include suggested changes, unsure whether those are the changes you asked for.
Ah, i didn't notice the PORTDOCS/pkg-plist thing, nice. What i was suggesting was: Turn .if ${PORT_OPTIONS:MDOCS}, into DOCS_PORTDOCS= DOCS_VARS=DOCSDIR= DOCS_VARS=PYDISTUTILS_BUILD_TARGET+= And turn post-install: into post-install-docs-ON:
Created attachment 162897 [details] patch-v3 another version, probably even more reduced 8-}
@Kurt, Can you pop this up for review please so me and antoine can add some feedback for changes please
From what I can see, the patch does not work for the DOCS stuff (tested, did not find the DOCS in stage/usr/local/share/doc.
Review: https://reviews.freebsd.org/D4106
Note: running the test via do-test target installs the test-depends, which reduces the number of test failures.
New tests with TEST_DEPENDS installed: 7.1.2: collected 566 items ======== 7 failed, 552 passed, 7 skipped, 1 warnings in 1072.95 seconds ======== 7.0.3: collected 555 items ======== 9 failed, 539 passed, 7 skipped, 1 warnings in 1038.99 seconds ========
review was OK'ed. Change of maintainer to python was OK'ed in the review, too.
net/py-tweepy builds fine sysutils/osquery fails on databases/rocksdb, which does not seem to be caused by pip.
This is the error for osquery: /usr/local/lib/librocksdb.a(format.o): In function `rocksdb::LZ4_Uncompress(char const*, unsigned long, int*, unsigned int)': /usr/ports/databases/rocksdb/work/rocksdb-4.0/./util/compression.h:549: undefined reference to `LZ4_decompress_safe'
A commit references this bug: Author: pi Date: Sat Nov 14 15:02:50 UTC 2015 New revision: 401574 URL: https://svnweb.freebsd.org/changeset/ports/401574 Log: devel/py-pip: 7.0.3 -> 7.1.2 Changes: https://pip.pypa.io/en/stable/news/ See also: https://reviews.freebsd.org/D4106 PR: 204367 Reviewed by: antoine, koobs, nivit Approved by: nivit (maintainer) Changes: head/devel/py-pip/Makefile head/devel/py-pip/distinfo head/devel/py-pip/files/patch-setup.cfg head/devel/py-pip/files/patch-setup.py head/devel/py-pip/pkg-plist
Committed.