Bug 204397 - security/keepass: Depends on x11/xsel but expects x11/xsel-conrad's CLI api
Summary: security/keepass: Depends on x11/xsel but expects x11/xsel-conrad's CLI api
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason Unovitch
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-11-09 11:12 UTC by Alex Zhukov
Modified: 2015-12-23 20:25 UTC (History)
4 users (show)

See Also:
woodsb02: maintainer-feedback+
junovitch: merge-quarterly+


Attachments
Patch to update security/keepass port to use x11/xsel-conrad instead of x11/xsel (622 bytes, patch)
2015-11-21 18:56 UTC, Ben Woods
woodsb02: maintainer-approval+
Details | Diff
QA: Successful poudriere testport logs with new x11/xsel-conrad dependency on FreeBSD current amd64 (61.13 KB, text/plain)
2015-11-21 18:57 UTC, Ben Woods
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Zhukov 2015-11-09 11:12:34 UTC
When installing the keepass binary package, it pulls in x11/xsel as a dependancy and copying passwords to the clipboard does not work. Keepass expects xsel to understand xsel-conrad command line switches.

I fixed this by building keepass from ports, deselecting xsel in the config menu and installing xsel-conrad manually.

Possible fix: change the dependency to xsel-conrad or patch keepass to use x11/xsel cli api.
Comment 1 Ben Woods freebsd_committer freebsd_triage 2015-11-21 18:56:37 UTC
Created attachment 163377 [details]
Patch to update security/keepass port to use x11/xsel-conrad instead of x11/xsel

Thank you for reporting this problem and proposing the fix to depend on x11/xsel-conrad instead of x11/xsel. I have tested this and can confirm it does indeed fix the copy to clipboard. The attached patch will implement this change in dependency.
Comment 2 Ben Woods freebsd_committer freebsd_triage 2015-11-21 18:57:35 UTC
Created attachment 163378 [details]
QA: Successful poudriere testport logs with new x11/xsel-conrad dependency on FreeBSD current amd64
Comment 3 Ben Woods freebsd_committer freebsd_triage 2015-11-21 19:02:00 UTC
Koobs: this is ready to be committed. Can it please also be merged to quarterly?
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-22 03:49:05 UTC
@Ben, I'd already set the merge-quarterly flag, so it's up to the committer who takes this issue to do so
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-12-23 00:41:11 UTC
A commit references this bug:

Author: junovitch
Date: Wed Dec 23 00:40:33 UTC 2015
New revision: 404272
URL: https://svnweb.freebsd.org/changeset/ports/404272

Log:
  security/keepass: fix XSEL option dependency

  - Switch x11/xsel -> x11/xsel-conrad. This resolves a run time issue
    when copying passwords to the clipboard.

  PR:		204397
  Reported by:	Alex Zhukov <baron.pampa@gmail.com>
  Submitted by:	Ben Woods <woodsb02@gmail.com> (maintainer)
  MFH:		2015Q4

Changes:
  head/security/keepass/Makefile
Comment 6 Jason Unovitch freebsd_committer freebsd_triage 2015-12-23 01:20:43 UTC
(In reply to Ben Woods from comment #3)
Awaiting approval on the MFH now.
Comment 7 Ben Woods freebsd_committer freebsd_triage 2015-12-23 08:09:41 UTC
(In reply to Jason Unovitch from comment #6)
> Awaiting approval on the MFH now.

If it is my permission as maintainer that you are waiting for to MFH, you have it.
Bugzilla will not let me set the merge-quarterly flag to a positive status.
Comment 8 Ben Woods freebsd_committer freebsd_triage 2015-12-23 08:09:41 UTC
(In reply to Jason Unovitch from comment #6)
> Awaiting approval on the MFH now.

If it is my permission as maintainer that you are waiting for to MFH, you have it.
Bugzilla will not let me set the merge-quarterly flag to a positive status.
Comment 9 commit-hook freebsd_committer freebsd_triage 2015-12-23 20:19:14 UTC
A commit references this bug:

Author: junovitch
Date: Wed Dec 23 20:18:57 UTC 2015
New revision: 404317
URL: https://svnweb.freebsd.org/changeset/ports/404317

Log:
  MFH: r404272

  security/keepass: fix XSEL option dependency

  - Switch x11/xsel -> x11/xsel-conrad. This resolves a run time issue
    when copying passwords to the clipboard.

  PR:		204397
  Reported by:	Alex Zhukov <baron.pampa@gmail.com>
  Submitted by:	Ben Woods <woodsb02@gmail.com> (maintainer)
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2015Q4/
  branches/2015Q4/security/keepass/Makefile
Comment 10 Jason Unovitch freebsd_committer freebsd_triage 2015-12-23 20:25:39 UTC
All, thanks for working together on finding and testing the resolution to this!

(In reply to Ben Woods from comment #8)
Commits to the quarterly branch must be approved by ports-secteam or portmgr.  In this case, I realized after going to bed that the following blanket approval for this as a "reliability" fix would have been appropriate and I could have immediately MFH'd the update.  However, I got the approval today while I was at work anyway.

"Backport of security and reliability fixes which only result in PORTREVISION bumps and no changes to enabled features."

https://wiki.freebsd.org/ports-secteam#Blanket_Approval

- Set PR to closed/fixed
- Set merge-quarterly+ (approved by ports-secteam (feld))