Bug 204490 - net/gtk-vnc Please enable python and gtk2 options
Summary: net/gtk-vnc Please enable python and gtk2 options
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
Keywords: easy, needs-patch, needs-qa
Depends on:
Reported: 2015-11-12 07:33 UTC by Will B
Modified: 2018-03-24 16:00 UTC (History)
6 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Note You need to log in before you can comment on or make changes to this bug.
Description Will B 2015-11-12 07:33:03 UTC

Please enable '--with-gtk=2.0' and '--with-python' on this package. I cannot use this package as-is with py27-gtk because of these missing options.  

If you cannot enable these by default, can you please fix the ports files so these options can be selected through `make config` when building from the ports tree?  I cannot use this package at all without being able to enable these options, and must build from external sources and the resulting package crashes constantly.

Thank you! :-)
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-12 08:23:00 UTC
Thanks for your report Will.

@Maintainer, alternatively, python/gtk2 sub ports might be possible if they cant or shouldn't be bundled within the one port/package.
Comment 2 Walter Schwarzenfeld freebsd_triage 2018-01-12 13:39:49 UTC
Is this still relevant? (Makefile shows USES=gtk30, but not python). If not, please close this PR.
Comment 3 Ting-Wei Lan 2018-01-12 16:16:10 UTC
(In reply to w.schwarzenfeld from comment #2)
Makefile has --without-python.

I think what the reporter want is a new port or a flavor of gtk-vnc that is built with GTK+ 2. The net/gtk-vnc port currently only supports GTK+ 3. GTK+ 3 version uses GObject introspection for its python binding, so there is no need to support python directly in gtk-vnc itself and I think it is why it uses --without-python.
Comment 4 Yuri Victorovich freebsd_committer 2018-01-12 18:26:12 UTC
The port option GTK2 should be added, IMO.
Comment 5 Yuri Victorovich freebsd_committer 2018-01-12 18:27:46 UTC
Possibly, python binding should be a separate package.
Comment 6 Roman Bogorodskiy freebsd_committer 2018-03-24 16:00:48 UTC
(In reply to Yuri Victorovich from comment #5)

As of gtk-vnc 0.7.2, python binding is deprecated and will be removed in the next release [1], I think it doesn't make much sense to add support for it now.

I've submitted a PR [2] that updates the port to 0.7.2 and allows to switch between GTK2 and GTK3.

1: https://www.berrange.com/posts/2018/03/23/announce-gtk-vnc-0-7-2-release/
2: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226895