Bug 204496 - devel/subversion, security/subversion-gnome-keyring, security/subversion-kwallet: fix pkgconfig files
Summary: devel/subversion, security/subversion-gnome-keyring, security/subversion-kwal...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Lev A. Serebryakov
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-11-12 11:36 UTC by Dmitry Marakasov
Modified: 2015-11-15 11:11 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (lev)
koobs: merge-quarterly?


Attachments
Patch (4.74 KB, patch)
2015-11-12 11:36 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-11-12 11:36:51 UTC
Created attachment 163047 [details]
Patch

- Fix pkgconfig files location
- Add missing pkgconfig files to slave ports security/subversion-gnome-keyring and security/subversion-kwallet
- Strip libraries
- Switch some more bits to options helpers
Comment 1 Lev A. Serebryakov freebsd_committer freebsd_triage 2015-11-12 13:07:59 UTC
Hmmm. Why are *.pc files moved? I don't have any problems with them on 'check-plist' target!

% find work/stage -name \*.pc
work/stage/usr/local/share/pkgconfig/libsvn_wc.pc
work/stage/usr/local/share/pkgconfig/libsvn_ra_serf.pc
work/stage/usr/local/share/pkgconfig/libsvn_delta.pc
work/stage/usr/local/share/pkgconfig/libsvn_fs_util.pc
work/stage/usr/local/share/pkgconfig/libsvn_subr.pc
work/stage/usr/local/share/pkgconfig/libsvn_fs_fs.pc
work/stage/usr/local/share/pkgconfig/libsvn_client.pc
work/stage/usr/local/share/pkgconfig/libsvn_ra.pc
work/stage/usr/local/share/pkgconfig/libsvn_fs.pc
work/stage/usr/local/share/pkgconfig/libsvn_diff.pc
work/stage/usr/local/share/pkgconfig/libsvn_fs_x.pc
work/stage/usr/local/share/pkgconfig/libsvn_ra_svn.pc
work/stage/usr/local/share/pkgconfig/libsvn_repos.pc
work/stage/usr/local/share/pkgconfig/libsvn_ra_local.pc
% svnversion
401341
%

Also, STRIP should depend on MAINTAINER_DEBUG option setting, IMHO.
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-11-14 14:44:22 UTC
(In reply to Lev A. Serebryakov from comment #1)
> Hmmm. Why are *.pc files moved?

Because they belong to libdata/pkgconfig

> I don't have any problems with them on 'check-plist' target!

There are check-plist problems with security/subversion-*

http://poudriere.amdmi3.ru/data/10-amd64-default/failures_all_2015_11_09/logs/errors/subversion-gnome-keyring-1.9.2.log
http://poudriere.amdmi3.ru/data/10-amd64-default/failures_all_2015_11_09/logs/errors/subversion-kwallet-1.9.2.log

> Also, STRIP should depend on MAINTAINER_DEBUG option setting, IMHO.

STRIP alread respects WITH_DEBUG (not stripping anything when WITH_DEBUG is enabled).
Comment 3 Lev A. Serebryakov freebsd_committer freebsd_triage 2015-11-14 16:00:02 UTC
(In reply to Dmitry Marakasov from comment #2)

Please note, that MAINTAINER_DEBUG is more specific than DEBUG.
Comment 4 Lev A. Serebryakov freebsd_committer freebsd_triage 2015-11-15 11:10:44 UTC
Committed, thnx!
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-11-15 11:11:18 UTC
A commit references this bug:

Author: lev
Date: Sun Nov 15 11:10:27 UTC 2015
New revision: 401689
URL: https://svnweb.freebsd.org/changeset/ports/401689

Log:
   (1) Place pkgconfig files to proper directory (libdata)
   (2) Strip binaries and libraries if MAINTAINER_DEBUG is not set
   (3) Set WITH_DEBUG if MAINTAINER_DEBUG option is selected

  PR:		204496
  Submitted by:	Dmitry Marakasov <amdmi3@FreeBSD.org>

Changes:
  head/devel/subversion/Makefile
  head/devel/subversion/Makefile.common
  head/devel/subversion/pkg-plist
  head/security/subversion-gnome-keyring/Makefile
  head/security/subversion-gnome-keyring/pkg-plist
  head/security/subversion-kwallet/Makefile
  head/security/subversion-kwallet/pkg-plist