Bug 204514 - devel/hadoop2: Create rc.d script for ZKFC
Summary: devel/hadoop2: Create rc.d script for ZKFC
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Sivachenko
URL:
Keywords: feature, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-11-13 08:39 UTC by Johannes Jost Meixner
Modified: 2015-11-18 18:29 UTC (History)
2 users (show)

See Also:
xmj: maintainer-feedback? (demon)

Attachments
Hadoop 2.7.1_1 with zkfailovercontroller rc.d script (2.01 KB, patch)
2015-11-13 08:39 UTC, Johannes Jost Meixner 		koobs: maintainer-approval? (demon)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Jost Meixner freebsd_committer freebsd_triage 2015-11-13 08:39:44 UTC 
Created attachment 163082 [details]
Hadoop 2.7.1_1 with zkfailovercontroller rc.d script

ZKFC (Zookeeper Failover Controller) is used for switching between two namenodes (in active/standby configuration).

So far an rc.d script for easy startup has been lacking, patch attached fixes this.
Comment 1 Dmitry Sivachenko freebsd_committer freebsd_triage 2015-11-13 10:23:53 UTC 
May be name this scrips shorter, say "zkfc"?
Comment 2 Johannes Jost Meixner freebsd_committer freebsd_triage 2015-11-16 14:30:15 UTC 
That's one option, but does the name speak for itself enough?
Comment 3 Dmitry Sivachenko freebsd_committer freebsd_triage 2015-11-16 14:52:12 UTC 
Well, tastes differ.

This is like fsck vs filesystemcheck :)

But zkfc matches hadoop-daemon.sh subcommand:
hadoop-daemon.sh start zkfc
Comment 4 Kevin Bowling freebsd_committer freebsd_triage 2015-11-16 21:18:52 UTC 
This is bike shed territory, but zkfc is consistent with the other init scripts.  Other OSes use something like hadoop-{name}.
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-11-18 13:21:09 UTC 
A commit references this bug:

Author: demon
Date: Wed Nov 18 13:20:35 UTC 2015
New revision: 401865
URL: https://svnweb.freebsd.org/changeset/ports/401865

Log:
  Add startup script for Zookeeper Failover Controller.

  PR:             204514
  Submitted by:   xmj

Changes:
  head/devel/hadoop2/Makefile
  head/devel/hadoop2/files/zkfc.in
Comment 6 Dmitry Sivachenko freebsd_committer freebsd_triage 2015-11-18 13:21:51 UTC 
Okay, I added it as "zkfc" for now.

We can consider renaming all startup scripts to be more clear they are hadoop babies.
Comment 7 Johannes Jost Meixner freebsd_committer freebsd_triage 2015-11-18 18:29:38 UTC 
Thanks for the commit (: