Bug 204900 - ports-mgmt/portlint: teach new pkg-plist keywords
Summary: ports-mgmt/portlint: teach new pkg-plist keywords
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-29 20:36 UTC by Olli Hauer
Modified: 2015-12-19 21:28 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olli Hauer freebsd_committer freebsd_triage 2015-11-29 20:36:55 UTC 
I was running portlint -C against a test port and got the following complain

$ portlint -C
WARN: pkg-plist: unknown pkg-plist directive "@sample(%%TESTUSER%%,%%TESTGROUP%%,440) file.sample"
WARN: pkg-plist: unknown pkg-plist directive "@preunexec ...
WARN: pkg-plist: unknown pkg-plist directive "@postunexec ...

Haven't tested the other new keywords, but I suspect they are also unknown with '-C'

From ports/CHANGES:
20150926:
AUTHOR: bapt@FreeBSD.org

  New keywords are supported in pkg since 1.5.x:
  @preexec <command>: execute the <command> during pre-install scripts
  @postexec <command>: execute the <command> during post-install scripts
  @preunexec <command>: execute the <command> during pre-deinstall scripts
  @postunexec <command>: execute the <command> during post-deinstall scripts

  @exec does not specify when if should be executed and is now considered as
  deprecated.

Additional the @sample keyword get some additions (CHANGES:20150926).
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2015-12-19 20:53:59 UTC 
Fixes committed to my CVS repo pending the next release.
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2015-12-19 21:17:32 UTC 
New support added in 2.16.8.
Comment 3 Olli Hauer freebsd_committer freebsd_triage 2015-12-19 21:28:30 UTC 
Nice, a quick test with your CVS version looks good to me :)

Thanks!