Bug 204935 - devel/py-icalendar: Allow build with Python 3.x, Update to 3.9.1
Summary: devel/py-icalendar: Allow build with Python 3.x, Update to 3.9.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-12-01 14:29 UTC by Christian Geier
Modified: 2015-12-14 11:40 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback+
koobs: merge-quarterly+


Attachments
patch for devel/py-icalendar Makefile (390 bytes, patch)
2015-12-01 14:29 UTC, Christian Geier
koobs: maintainer-approval+
Details | Diff
output of make'ing py-icalendar with PYTHON_VERSION=3.4 (13.16 KB, text/plain)
2015-12-02 12:25 UTC, Christian Geier
no flags Details
patch for devel/py-icalendar (1.13 KB, patch)
2015-12-02 16:28 UTC, jun-g
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Geier 2015-12-01 14:29:22 UTC
Created attachment 163707 [details]
patch for devel/py-icalendar Makefile

icalendar supports python 3 since some time, there is no need to fix the python version to 2.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-02 08:17:35 UTC
@Christian, could you attach a successful poudriere build log with Python 3.x to confirm please?
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-02 11:59:12 UTC
If the quarterly version of this port is incorrectly limited to Python 2.x in the same way, this is an MFH candidate
Comment 3 Christian Geier 2015-12-02 12:25:06 UTC
Created attachment 163752 [details]
output of make'ing py-icalendar with PYTHON_VERSION=3.4

 this is the output of `make stage && make check-plist && make stage-qa && make package` with PYTHON_VERSION=3.4
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-02 12:44:12 UTC
Thank you Christian!
Comment 5 jun-g 2015-12-02 16:28:25 UTC
Created attachment 163778 [details]
patch for devel/py-icalendar

Thank you Chirstian!
I created a new patch.
* Update to 3.9.1.
* Support python3.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-03 06:56:28 UTC
@Jun-G, with your approval I'd like to commit the change for USES=python independently from the version update, so I can merge the former to the quarterly branch, without the version update.

Can you please approve attachment 163707 [details]
Comment 7 jun-g 2015-12-03 15:42:29 UTC
Comment on attachment 163707 [details]
patch for devel/py-icalendar Makefile

I approved this patch.
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-12-14 11:02:59 UTC
A commit references this bug:

Author: koobs
Date: Mon Dec 14 11:02:40 UTC 2015
New revision: 403713
URL: https://svnweb.freebsd.org/changeset/ports/403713

Log:
  devel/py-icalendar: Allow build with Python 3.x

  Allow building with Python 3.x (Supported since 3.6)

  While I'm here,

   * Add LICENSE_FILE

  PR:		204935
  Submitted by:	Christian Geier <catcher+freebsdbugzilla lostpackets de>
  Approved by:	maintainer <jun-g daemonfreaks com>
  MFH:		2015Q4

Changes:
  head/devel/py-icalendar/Makefile
Comment 9 commit-hook freebsd_committer freebsd_triage 2015-12-14 11:06:01 UTC
A commit references this bug:

Author: koobs
Date: Mon Dec 14 11:05:12 UTC 2015
New revision: 403714
URL: https://svnweb.freebsd.org/changeset/ports/403714

Log:
  MFH: r403713

  devel/py-icalendar: Allow build with Python 3.x

  Allow building with Python 3.x (Supported since 3.6)

  While I'm here,

   * Add LICENSE_FILE

  PR:		204935
  Submitted by:	Christian Geier <catcher+freebsdbugzilla lostpackets de>
  Approved by:	maintainer <jun-g daemonfreaks com>

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2015Q4/
  branches/2015Q4/devel/py-icalendar/Makefile
Comment 10 commit-hook freebsd_committer freebsd_triage 2015-12-14 11:39:10 UTC
A commit references this bug:

Author: koobs
Date: Mon Dec 14 11:38:58 UTC 2015
New revision: 403717
URL: https://svnweb.freebsd.org/changeset/ports/403717

Log:
  devel/py-icalendar: Update to 3.9.1

   * Update PORTVERSION and distinfo checksum (3.9.1) [1]

  While I'm here:

   * Add USE_PYTHON=concurrent support, deprecate DOCSDIR accordingly
   * Add test target and patch setup.py to support test command
   * Update pkg-descr WWW URL to match setup.py:url= field

  Changes:

    https://github.com/collective/icalendar/blob/3.9.1/CHANGES.rst

  PR:		204935
  Submitted by:	maintainer <jun-g daemonfreaks com> [1]

Changes:
  head/devel/py-icalendar/Makefile
  head/devel/py-icalendar/distinfo
  head/devel/py-icalendar/files/
  head/devel/py-icalendar/files/patch-setup.py
  head/devel/py-icalendar/pkg-descr
Comment 11 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-14 11:40:48 UTC
Committed with changes, thank you both. Apologies for the delay

Note: Only attachment 163707 [details] was merged (MFH) to 2015Q4