Bug 204966 - www/rssroll: make check-plist incorrectly returns/replaces path with %%WWWOWN%%
Summary: www/rssroll: make check-plist incorrectly returns/replaces path with %%WWWOWN%%
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-02 13:03 UTC by Nikola Kolev
Modified: 2016-01-04 10:28 UTC (History)
3 users (show)

See Also:
koue: maintainer-feedback+
koobs: merge-quarterly-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikola Kolev 2015-12-02 13:03:32 UTC
Hi,

While I was updating one of my ports 'make check-plist' returns:

...
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%WWWOWN%%/data/rssroll/html/flak/header.html
===> Checking for items in pkg-plist which are not in STAGEDIR
...

I guess %%WWWOWN%% should be replaced by %%%WWWDIR%%.

I've updated ports tree to the latest version with portsnap but %%WWWOWN%% still appears in the 'make check-plist' result.

Nikola
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-02 13:07:32 UTC
@Nikola, can you provide an svn diff against the port head for this change please?

Also, for future issue reports, for individual ports, always use the "Individual Ports(s)" component, and prefix "category/portname:" to the issue summary field, so they are automatically assigned :)
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-12-02 14:12:29 UTC
Kubilay, please read the problem more carefully.
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2015-12-02 14:52:20 UTC
The problem is that your port writes files into PREFIX/www directly, which it should not.

The port must install its files in PREFIX/WWWDIR.
Comment 4 Nikola Kolev 2015-12-02 14:55:29 UTC
Hi,

As Mathieu says:

I found the problem. Wrong install path of the port's files makes 'make check-plist' to returns:

Error: Orphaned: %%WWWOWN%%/data/rssroll/html/flak/header.html

Wrong install path of the port's files:
www/data/rssroll/html/flak/header.html

Corrent install path of the port's files:
www/rssroll/html/flak/header.html

With correct install path 'make check-plist' returns:

Error: Orphaned: %%WWWDIR%%/html/flak/header.html

I will correct the install paths of the files in the port and it will be OK.
But I want to notice %%WWWOWN%% or %%WWWGRP%% is not good idea to appear in the paths of the files returned by 'make check-plist'.

Nikola
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-03 11:16:38 UTC
(In reply to Dmitry Marakasov from comment #2)

@Dmitry, This is still reported 'for' www/rssroll, even if it ends up resulting in portmgr handling it, or the subsequent creation of a new 'blocking' Mk/ change, if someone (anyone) identifies a root-cause issue in the framework.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-03 11:17:18 UTC
@Nikola, if you have identified a change that needs to be made in the port, please attach an svn diff accordingly, thank you!
Comment 7 Nikola Kolev 2015-12-03 15:26:15 UTC
Hi,

If port's Makefile contains

PLIST_SUB=     WWWOWN=${WWWOWN} WWWGRP=${WWWGRP}

and ${WWWOWN} by default is 'www' (/usr/ports/Mk/bsd.port.mk) and if 'www' exists somewhere in the paths of the installed files from the port except 'www/${PORTNAME}' because it is ${WWWDIR} then 'make check-plist' returns:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/test/dir/%%WWWOWN%%/%%WWWOWN%%/%%WWWOWN%%.html
Error: Orphaned: %%WWWDIR%%/%%WWWOWN%%.html
===>

I reproduced this with another port from the ports tree by adding new installed files which paths contain 'www'. Installed files paths are:

lib/test/dir/www/www/www.html
www/portname/www.html

In my opinion %%WWWOWN%% and %%WWWGRP%% should not be replaced in file path by 'make check-plist' because they are responsible for ownership of the files.

I fixed my rssroll port with correct install paths and everything is OK but if someone uses PLIST_SUB, WWWOWN and 'www' in installed files will be surprised (like me) why 'make check-plist' recommends using of %%WWWOWN%% in file path in pkg-plist.

If this is expected behavior I'm OK the bug to be closed.

Nikola
Comment 8 Nikola Kolev 2016-01-04 10:09:27 UTC
Please close this issue.
Comment 9 Martin Wilke freebsd_committer freebsd_triage 2016-01-04 10:13:55 UTC
Close per request.