Bug 204977 - [PATCH] java/openjdk8: Use late in pkg-message's fstab entries
Summary: [PATCH] java/openjdk8: Use late in pkg-message's fstab entries
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-java (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-12-02 21:56 UTC by Tobias Kortkamp
Modified: 2016-07-24 13:16 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (java)


Attachments
openjdk8.diff (449 bytes, patch)
2015-12-02 21:56 UTC, Tobias Kortkamp
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2015-12-02 21:56:19 UTC
Created attachment 163784 [details]
openjdk8.diff

The pkg-message for openjdk8 suggests adding two fstab entries.  But when using a separate boot partition (or boot pool with a standard ZFS configuration as proposed by the installer when using encryption) adding them can lead to the system booting to single user mode (see https://forums.freebsd.org/threads/11-current-boots-to-single-user-with-fdescfs-linprocfs-in-fstab.53163/#post-298637).  Either loading fdescfs(5) (and procfs(5) but that is part of GENERIC) from /boot/loader.conf or adding the late option fixes the problem for those systems AFAICT (see attached patch).

This also affects the pkg-message of shells/bash.
Comment 1 Jung-uk Kim freebsd_committer freebsd_triage 2015-12-02 22:14:32 UTC
These are almost direct copy-and-paste from fdescfs(5) and procfs(5).

https://www.freebsd.org/cgi/man.cgi?query=fdescfs&manpath=FreeBSD+10.2-RELEASE
https://www.freebsd.org/cgi/man.cgi?query=procfs&manpath=FreeBSD+10.2-RELEASE

I don't see any reason to change the message. :-/
Comment 2 Andrew Smith 2016-05-18 09:30:48 UTC
(In reply to Jung-uk Kim from comment #1)

I'm not sure if you missed the significance of the 'late' flag and the very good response to the post on the forum.

It sounds like a simple update to the mount option suggestions, either this or a note about the particular issue experienced by the op on the thread could save people a lot of fishing around for an answer.
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2016-07-09 15:57:07 UTC
(In reply to Andrew Smith from comment #2)
> could save people a lot of fishing around for an answer
Yes, that was the reason for opening this PR.

(In reply to Jung-uk Kim from comment #1)
> These are almost direct copy-and-paste from fdescfs(5) and procfs(5).
So you're saying that fdescfs(5) and procfs(5) need an update too? ;-)

If nobody wants this please reject it and let's close this PR.  Don't leave it hanging around forever.  I consider > 6 months too long for stuff like this.  The cost of changing it is so low.  It's not like changing a pkg message will break any functionality.