Created attachment 163909 [details] Patch to fix "cd: /usr/[...]/work/base: No such file or directory" When I tried to install games/ufoai yesterday (from ports as there was no pkg for 10.2 amd64) ufoai-data failed: => SHA256 Checksum OK for ufoai/ufoai-2.5-data.tar. ===> ufoai-data-2.5 depends on file: /usr/local/bin/unzip - found cd: /usr/ports/games/ufoai-data/work/base: No such file or directory *** Error code 2 Stop. make[1]: stopped in /usr/ports/games/ufoai-data *** Error code 1 I checked /usr/ports/games/ufoai-data/work/ and found "ufoai-data-2.5" with a subdir named "base". After inserting "${PKGNAMEPREFIX}${PORTNAME}-${PORTVERSION}/" into every occurrence of "${WRKDIR}/base" (see attached patch) I could install and play the game.
Hey. Thanks for reporting that. but don't like the way how you have fixed it. Why do not you just fix ${WRKDIR} itself?
(In reply to m.tsatsenko from comment #1) Oh, sorry, I just forgot to look into setting WRKDIR between the first change which only fixed the build and the later ones allowing the game to actually run. When I understand the Porter's Handbook "Specifying the Working Directory" [0] correctly I should set WRKSRC to the subdir in question, right? [0] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-wrkdir.html
Created attachment 164150 [details] Setting WRKSRC instead of specifying WRKDIR's subdir all the time 2nd try.
Hi! You got the idea, but the patch is wrong. You are still modifying each line where ${WRKSRC} is used
I will submit my own patch soon
Created attachment 164574 [details] patch I am sorry. Seems you were almost right. The problem was a typo ${WRKDIR} instead of ${WRKSRC}. The patch fixes it
Thanks guys. Can you confirm testing (portlint, poudriere) passes? Does the approved patch obsolete the previous one? Maintainer feedback complete?
A commit references this bug: Author: riggs Date: Thu Dec 31 20:48:04 UTC 2015 New revision: 404960 URL: https://svnweb.freebsd.org/changeset/ports/404960 Log: Fix build failure PR: 205069 Submitted by: florian.ermisch@alumni.tu-berlin.de Reviewed by: m.tsatsenko@gmail.com (maintainer) Approved by: m.tsatsenko@gmail.com (maintainer) Changes: head/games/ufoai-data/Makefile
I don't think this is finished. Doesn't the PLIST need the fix too? e.g. @@ -29,19 +29,19 @@ NO_WRKSUBDIR= yes NO_ARCH= yes DATADIR= share/${PKGNAMEPREFIX:S/-//} -PLIST= ${WRKDIR}/pkg-plist +PLIST= ${WRKSRC}/pkg-plist
(In reply to John Marino from comment #9) For consistency, we could generate the PLIST in WRKSRC instead of WRKDIR, true. However it is not necessary for plist generation to work in this case, since everything is generated dynamically and collected into ${PLIST}. Before committing, I had a couple of poudriere runs on different OSVERSIONs to verify.