Bug 205452 - emulators/virtualbox-ose-kmod: patch needed after vm_pageout_grow_cache() removed
Summary: emulators/virtualbox-ose-kmod: patch needed after vm_pageout_grow_cache() rem...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jung-uk Kim
URL:
Keywords: needs-qa, patch, patch-ready, regression
Depends on:
Blocks:
 
Reported: 2015-12-20 06:00 UTC by Mark Johnston
Modified: 2015-12-21 22:35 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (vbox)

Attachments
virtualbox patch update (3.32 KB, patch)
2015-12-20 06:00 UTC, Mark Johnston 		no flags Details | Diff
Fix build after vm_pageout_grow_cache() removal (3.35 KB, patch)
2015-12-21 20:49 UTC, Jung-uk Kim 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Johnston freebsd_committer freebsd_triage 2015-12-20 06:00:56 UTC 
Created attachment 164410 [details]
virtualbox patch update

A recent change to the base system (r292469) removed a VM function that the virtualbox kernel modules uses. I've attached a patch which fixes it. See https://lists.freebsd.org/pipermail/freebsd-current/2015-December/059005.html

I note that the patch (generated by "make makepatch") contains some unrelated cosmetic changes, but from reading the makepatch script, they appear to be intended.
Comment 1 Jung-uk Kim freebsd_committer freebsd_triage 2015-12-21 20:00:33 UTC 
I'll take it.
Comment 2 Jung-uk Kim freebsd_committer freebsd_triage 2015-12-21 20:49:47 UTC 
Created attachment 164465 [details]
Fix build after vm_pageout_grow_cache() removal

Please try this patch and let me know.
Comment 3 Mark Johnston freebsd_committer freebsd_triage 2015-12-21 21:57:39 UTC 
It seems to be ok. I omitted the VM_WAIT in my original patch because I can't tell if that code might be executed in a non-sleepable context.
Comment 4 Jung-uk Kim freebsd_committer freebsd_triage 2015-12-21 22:28:41 UTC 
(In reply to Mark Johnston from comment #3)
Actually, I am not 100% sure whether we can sleep any more.  I'll just commit yours for now.
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-12-21 22:34:28 UTC 
A commit references this bug:

Author: jkim
Date: Mon Dec 21 22:34:02 UTC 2015
New revision: 404195
URL: https://svnweb.freebsd.org/changeset/ports/404195

Log:
  Fix build on head after vm_pageout_grow_cache() removal.

  PR:		205452

Changes:
  head/emulators/virtualbox-ose/files/patch-src-VBox-Runtime-r0drv-freebsd-memobj-r0drv-freebsd.c
Comment 6 Jung-uk Kim freebsd_committer freebsd_triage 2015-12-21 22:35:51 UTC 
Committed (r404195), thanks!