Bug 205470 - devel/powerpc64-gcc: let slave ports define additional build dependencies
Summary: devel/powerpc64-gcc: let slave ports define additional build dependencies
Status: Closed Not A Bug
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Baptiste Daroussin
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2015-12-20 21:39 UTC by Oleksandr Tymoshenko
Modified: 2016-02-28 22:40 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bapt)

Attachments
powerpc64-gcc-build_depends.diff (608 bytes, patch)
2015-12-20 21:39 UTC, Oleksandr Tymoshenko 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleksandr Tymoshenko freebsd_committer freebsd_triage 2015-12-20 21:39:54 UTC 
Created attachment 164432 [details]
powerpc64-gcc-build_depends.diff

Append to BUILD_DEPENDS variable instead of setting it. This allows slave ports define additional dependencies. Existing ports do not need this functionality but upcoming devel/mips-none-elf-gcc port requires it
Comment 1 Baptiste Daroussin freebsd_committer freebsd_triage 2015-12-25 10:00:07 UTC 
Why not simply adding the new build dependency after including the master port makefile inside devel/mips-none-elf-gcc/Makefile

like

.include "${MASTERDIR}"/Makefile

BUILD_DEPENDS+= newdep
Comment 2 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2016-02-28 22:40:58 UTC 
portlint complains if there is anything after ".include" line. But it's, probably more portlint issue. Closing this one