Bug 205574 - news/newsstar: cleanup
Summary: news/newsstar: cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-24 12:03 UTC by Dmitry Marakasov
Modified: 2015-12-30 15:17 UTC (History)
0 users

See Also:
mandree: maintainer-feedback+

Attachments
Patch (2.32 KB, patch)
2015-12-24 12:04 UTC, Dmitry Marakasov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-12-24 12:03:49 UTC 
- Switch to options helpers
- Drop @dirrm's from plist
- Handle vardirs properly
- Switch to @postunexec

Please check whether /var/spool/newsstar needs news,news,750 permissions as well, or it just holds other two directories.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2015-12-24 12:04:04 UTC 
Created attachment 164594 [details]
Patch
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-12-30 15:16:41 UTC 
A commit references this bug:

Author: mandree
Date: Wed Dec 30 15:16:27 UTC 2015
New revision: 404861
URL: https://svnweb.freebsd.org/changeset/ports/404861

Log:
  Cleanup and update.

  PR:		205574
  Submitted by:	Dmitry Marakasov (amdmi3@)

Changes:
  head/news/newsstar/Makefile
  head/news/newsstar/pkg-plist
Comment 3 Matthias Andree freebsd_committer freebsd_triage 2015-12-30 15:17:53 UTC 
Thanks, fixed. Apparently the /var/spool/newsstar only holds the two subdirs, so that your patch is correct in that regard by not assigning it to news:news, but leaving up to root:wheel.