Created attachment 164889 [details] Makefile patch Fix build in FreeBSD 10+ recent ticket number is bug #195886
I'm working on it.
@Gasol, is attachment 164889 [details] insufficient? Please detail how/why
Note that this port depends on expired lang/php5 (PHP 5.4), so it is still scheduled for removal soon. Is it possible to update this port to work with lang/php55 or lang/php56 ?
(In reply to Rene Ladan from comment #3) Hi all, My patch does not set dependency on PHP 5.4 (see https://bugs.freebsd.org/bugzilla/attachment.cgi?id=164889&action=diff) If PHP 5.4 would be expired, the new lang/php5 (maybe lang/php55 or lang/php56, etc.) will be supported. Besides, I have compiled and used databases/php5-pdo_cassandra in PHP 5.5+ environments. If need new patch to set default PHP version, please let me know. Thanks a lot -- stephon
I think that indeed a lot of ports that are marked as depending on PHP 5.4 (lang/php5) can be converted to work with the default PHP version (currently 5.6). Antoine@, what do you think? Should all individual maintainers update their ports or can we convert them ourselves?
Except of course all php5-* ports that are part of lang/php5 (PHP 5.4) itself.
(In reply to Rene Ladan from comment #6) Hi Rene, How about resending this PR as databases/php55-pdo_cassandra or databases/php56-pdo_cassandra? If ok, I would resend a new port PR to resolve this issue. Besides, since there are indeed lots of work to deal with php5-* ports, Maybe we could notice php5-* ports maintainers to migrate into lang/php5[5-6]. Thanks a lot. --- stephon
(In reply to Rene Ladan from comment #5) which ports? for instance cakephp* we have in the tree are outdated/affected by security vulns
(In reply to Rene Ladan from comment #5) > I think that indeed a lot of ports that are marked as depending on PHP 5.4 > (lang/php5) can be converted to work with the default PHP version > (currently 5.6). > Antoine@, what do you think? Should all individual maintainers update > their ports or can we convert them ourselves? I'm not Antoine, but: There are quite a number of incompatible backward-changes: http://php.net/manual/en/migration55.incompatible.php http://php.net/manual/en/migration56.incompatible.php But i'm sure that most of them can be found in an automatic way.
Yes, one way would be to take the list of ports that got deprecated with PHP 5.4, change them to use the default version (5.6) and test-build them.
(In reply to Rene Ladan from comment #10) But a test-build won't show any problems with the PHP code of the project itself. They would build just fine and maybe fail on some specific areas. Even if every test-build is fine, its just luck if everything works after this.
Created attachment 166157 [details] patch file * Bump PORTREVISION * Fix regression bug occurs in thrift 0.9.3 which affect broken build , Please see https://issues.apache.org/jira/browse/THRIFT-3317 for more details. * Use compiler feature for flexibility * Remove unnecessary THRIFT_PORTVERSION * Refresh patches
Created attachment 166158 [details] test on 10.2-RELEASE
Created attachment 166159 [details] test on 11.0-CURRENT
(In reply to Torsten Zühlsdorff from comment #11) Agree, I just remove PHP_DEFAULT= 5.4, There is no reason to fork package into databases/php55-pdo_cassandra and databases/php56-pdo_cassandra, It works fine in any 5 version of PHP. including PHP5.4 (has deprecated), PHP5.5 and PHP5.6. Just respect DEFAULT_VERSION.
A commit references this bug: Author: rene Date: Tue Jan 26 22:58:37 UTC 2016 New revision: 407323 URL: https://svnweb.freebsd.org/changeset/ports/407323 Log: databases/php5-pdo_cassandra: unbreak - Do not hardcode expired PHP version - Fix regression with Thrift 0.9.3, see https://issues.apache.org/jira/browse/THRIFT-3317 - Use C++11 compiler via the Ports framework instead of hardcoding GCC - Bump PORTREVISION PR: 205749 Submitted by: stephon@gmail.com Approved by: Gasol Wu (maintainer) MFH: 2016Q1 Changes: head/databases/php5-pdo_cassandra/Makefile head/databases/php5-pdo_cassandra/files/patch-config.m4
A commit references this bug: Author: rene Date: Tue Jan 26 23:02:48 UTC 2016 New revision: 407324 URL: https://svnweb.freebsd.org/changeset/ports/407324 Log: MFH: r407323 databases/php5-pdo_cassandra: unbreak - Do not hardcode expired PHP version - Fix regression with Thrift 0.9.3, see https://issues.apache.org/jira/browse/THRIFT-3317 - Use C++11 compiler via the Ports framework instead of hardcoding GCC - Bump PORTREVISION PR: 205749 Submitted by: stephon@gmail.com Approved by: Gasol Wu (maintainer) Approved by: portmgr (bapt) Changes: _U branches/2016Q1/ branches/2016Q1/databases/php5-pdo_cassandra/Makefile branches/2016Q1/databases/php5-pdo_cassandra/files/patch-config.m4