Bug 205819 - security/py-letsencrypt: Installation breaks if any python dependency is previously installed via pip
Summary: security/py-letsencrypt: Installation breaks if any python dependency is prev...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kubilay Kocak
URL:
Keywords:
Depends on: 205881
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-03 06:33 UTC by Alberto Mijares
Modified: 2016-02-03 08:03 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Mijares 2016-01-03 06:33:42 UTC
Installing letsencrypt via ports is broken if a python dependency is previously installed via pip install. A warning should be displayed, at least. Ideally, if possible, the port should realize if the module is there because a pkg or pip install and do the right thing: (warn the user) or (pip uninstall && pkg install).
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-04 15:19:12 UTC
This issue was caused by the pip installation of $things into system site-packages, which shouldn't be done.

I've been meaning to add a stern warning to devel/py-pip about this, and asked Alberto to create an issue for it.

This is that issue, but I will create a blocking bug for the devel/py-pip change
Comment 2 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-01-20 21:01:33 UTC
(In reply to Kubilay Kocak from comment #1)

@Kubilay,

It's seems perfect :)
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-02-03 07:51:10 UTC
A commit references this bug:

Author: koobs
Date: Wed Feb  3 07:50:20 UTC 2016
New revision: 407947
URL: https://svnweb.freebsd.org/changeset/ports/407947

Log:
  devel/py-pip: Add pkg-message user WARNING

  Add a pkg-message warning users not to use pip to install packages in
  the system-wide Python environment location. This should have been done
  a long time ago.

  While I'm here:

  - Add LICENSE_FILE
  - Enable NO_ARCH
  - Match *_DEPENDS versions to those in setup.py
  - Fix incorrect pytest-xdist package name match

  PR:		205881, 205819
  Reported by:	many
  Suggested by:	many
  MFH:		2016Q1

Changes:
  head/devel/py-pip/Makefile
  head/devel/py-pip/pkg-message
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-02-03 08:01:14 UTC
A commit references this bug:

Author: koobs
Date: Wed Feb  3 08:00:35 UTC 2016
New revision: 407948
URL: https://svnweb.freebsd.org/changeset/ports/407948

Log:
  MFH: r407947

  devel/py-pip: Add pkg-message user WARNING

  Add a pkg-message warning users not to use pip to install packages in
  the system-wide Python environment location. This should have been done
  a long time ago.

  While I'm here:

  - Add LICENSE_FILE
  - Enable NO_ARCH
  - Match *_DEPENDS versions to those in setup.py
  - Fix incorrect pytest-xdist package name match

  PR:		205881, 205819
  Reported by:	many
  Suggested by:	many
  MFH:		2016Q1

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2016Q1/
  branches/2016Q1/devel/py-pip/Makefile
  branches/2016Q1/devel/py-pip/pkg-message
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2016-02-03 08:03:44 UTC
A warning message has been added to pip package installations in bug 205881

Any new features either in the framework, or in pip itself that adds the ability to detect these situations should be created in a separate issue.

Thank you for the report Alberto!