Bug 205900 - benchmarks/httperf: Update to 0.9.0.1 (latest on GitHub)
Summary: benchmarks/httperf: Update to 0.9.0.1 (latest on GitHub)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Julien Laffaye
URL:
Keywords: easy, patch
Depends on:
Blocks: 203675
  Show dependency tree / graph
 
Reported: 2016-01-04 19:22 UTC by Ryan Steinmetz
Modified: 2016-01-08 02:31 UTC (History)
2 users (show)

See Also:
jlaffaye: maintainer-feedback+

Attachments
patch to update to github master (2.44 KB, patch)
2016-01-04 19:22 UTC, Ryan Steinmetz 		no flags Details | Diff
updated patch (2.45 KB, patch)
2016-01-04 20:23 UTC, Ryan Steinmetz 		vlad-fbsd: maintainer-approval+
Details | Diff
build log (33.29 KB, text/plain)
2016-01-05 01:33 UTC, Ryan Steinmetz 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Steinmetz freebsd_committer freebsd_triage 2016-01-04 19:22:14 UTC 
Created attachment 165076 [details]
patch to update to github master

- Update to latest release in github
- Fix trailing whitespace in pkg-descr
- Pacify portlint
Comment 1 Ryan Steinmetz freebsd_committer freebsd_triage 2016-01-04 19:43:52 UTC 
I have opened an issue request for upstream to create a new release for us, however, they have not yet done this.
Comment 2 Ryan Steinmetz freebsd_committer freebsd_triage 2016-01-04 20:23:04 UTC 
Created attachment 165078 [details]
updated patch

Update patch
Comment 3 Ryan Steinmetz freebsd_committer freebsd_triage 2016-01-05 01:33:35 UTC 
Created attachment 165090 [details]
build log
Comment 4 Julien Laffaye freebsd_committer freebsd_triage 2016-01-07 07:53:06 UTC 
Plese commit, but wihtout the commented MASTER_SITES line :)
Comment 5 Bernard Spil freebsd_committer freebsd_triage 2016-01-07 20:49:28 UTC 
That patch is incomplete. Misses GH_ACCOUNT and GH_PROJECT at minimum, therefor doesn't build.
Comment 6 Bernard Spil freebsd_committer freebsd_triage 2016-01-07 20:58:46 UTC 
Please include this pull request as a patch in the port as well

https://github.com/httperf/httperf/pull/35
Comment 7 Ryan Steinmetz freebsd_committer freebsd_triage 2016-01-07 20:59:47 UTC 
(In reply to Bernard Spil from comment #5)
It builds fine.  Those are set to the defaults:

# In order to use GitHub your port must define USE_GITHUB and the following
# variables:
#
# GH_ACCOUNT    - account name of the GitHub user hosting the project
#                 default: ${PORTNAME}
#
# GH_PROJECT    - name of the project on GitHub
#                 default: ${PORTNAME}
Comment 8 Bernard Spil freebsd_committer freebsd_triage 2016-01-07 21:03:49 UTC 
(In reply to Ryan Steinmetz from comment #7)

Oops sorry, does indeed initial make failed and I jumped to conclusions.

Request to add the patch from Pull request #35 still stands! (fixes when you use WITH_OPENSSL_PORT=yes; WITH_OPENSSL=security/openssl and security_openssl_UNSET= SSL2 SSl3
Comment 9 commit-hook freebsd_committer freebsd_triage 2016-01-08 02:31:42 UTC 
A commit references this bug:

Author: zi
Date: Fri Jan  8 02:30:46 UTC 2016
New revision: 405507
URL: https://svnweb.freebsd.org/changeset/ports/405507

Log:
  - Update to 0.9.1 pre-release [2]
  - Add support for building when SSLv2 or SSLv3 are disabled [1]

  PR:		203675 [1], 205900 [2]
  Submitted by:	brnrd@ [1], zi@ [2]
  Reviewed by:	jlaffaye@ (maintainer)
  Approved by:	jlaffaye@ (maintainer)
  Obtained from:	upstream github

Changes:
  head/benchmarks/httperf/Makefile
  head/benchmarks/httperf/distinfo
  head/benchmarks/httperf/files/patch-nossl23
  head/benchmarks/httperf/pkg-descr