Bug 205919 - [patch] lang/mono: increase FD limit for kqueue-based FileSystemWatcher
Summary: [patch] lang/mono: increase FD limit for kqueue-based FileSystemWatcher
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-mono (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-01-05 11:45 UTC by Daniel Becker
Modified: 2016-01-16 12:14 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (mono)

Attachments
back-port the change to increase the FD limit from master (909 bytes, patch)
2016-01-05 11:45 UTC, Daniel Becker 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Becker 2016-01-05 11:45:09 UTC 
Created attachment 165099 [details]
back-port the change to increase the FD limit from master

The kqueue-based FileSystemWatcher implementation has a hard-coded limit of 200 file descriptors in both 4.2.1.124 and 4.2.2.10. This limit appears to be arbitrary, and it's gone in upstream master (now defaults to Int32.MaxValue). Attached patch back-ports the relevant change from master to allow watching directory hierarchies with more than 200 entries.
Comment 1 Daniel Becker 2016-01-05 11:46:27 UTC 
Note that this change is in Mono master, but not yet in any released version.
Comment 2 Daniel Becker 2016-01-05 18:36:53 UTC 
This fix is needed to allow real-time library monitoring in multimedia/emby-server to work with non-trivial media library sizes.
Comment 3 Romain Tartière freebsd_committer freebsd_triage 2016-01-07 10:16:37 UTC 
This is commit 2af882232ce4961fdbe1ba0ae36246456bb1fbfb upstream.

I'll commit it with the next lang/mono update I am working on ;-)
Comment 4 Romain Tartière freebsd_committer freebsd_triage 2016-01-16 12:14:10 UTC 
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-01-16 12:14:38 UTC 
A commit references this bug:

Author: romain
Date: Sat Jan 16 12:13:45 UTC 2016
New revision: 406211
URL: https://svnweb.freebsd.org/changeset/ports/406211

Log:
  Update to 4.2.2.10 [1]

  While here, add patch to increase FD limit for kqueue-based FileSystemWatcher
  [2].

  PR:		205902 [1], 205919 [2]
  Submitted by:	feld [1], razzfazz@gmail.com [2]

Changes:
  head/lang/mono/Makefile
  head/lang/mono/distinfo
  head/lang/mono/files/patch-eglib-src-gunicode.c
  head/lang/mono/files/patch-eglib_src_gfile-posix.c
  head/lang/mono/files/patch-mono_metadata_socket-io.c
  head/lang/mono/pkg-plist