Bug 206091 - lang/rust-nightly: Update to 1.7.0 (20160108)
Summary: lang/rust-nightly: Update to 1.7.0 (20160108)
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jean-Sébastien Pédron
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-01-10 07:36 UTC by oleksii.tsai
Modified: 2016-03-29 18:02 UTC (History)
1 user (show)

See Also:
dumbbell: maintainer-feedback+

Attachments
Patch with port updates. (9.86 KB, text/plain)
2016-01-10 07:36 UTC, oleksii.tsai 		no flags Details
Patch with port updates. Fixed. (10.17 KB, patch)
2016-01-11 00:48 UTC, oleksii.tsai 		dumbbell: maintainer-approval+
Details | Diff
Poudriere log (3.37 KB, text/plain)
2016-01-11 00:48 UTC, oleksii.tsai 		no flags Details
Poudriere build log (450.18 KB, text/plain)
2016-01-11 00:50 UTC, oleksii.tsai 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description oleksii.tsai 2016-01-10 07:36:29 UTC 
Created attachment 165347 [details]
Patch with port updates.

Proposed patch updates rust-nightly to 1.7.0 (20160108).
It also fixed configure args and fixes doc directory copying if DOCS options is set, i.e. rename rust to rust-nightly doc directory only if rust-nightly doesn't exist. If not done so, consequent build will put rust directory inside rust-nightly and eventually break the build.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-10 08:01:11 UTC 
@Oleksii, can you confirm this change passes QA (portlint, poudriere) please?
Comment 2 oleksii.tsai 2016-01-10 08:17:15 UTC 
(In reply to Kubilay Kocak from comment #1)
As for portlint, it gives several warnings. Some of them have been fixed with the patch, such as using find/chmod instead of ${FIND}/${CHMOD}. All the rest warnings are related to locations of some variable definitions. These variable definitions are where they were initially and remain unchanges. I can fix those warnings as well. Let me know is you want me to fix them.

As for poudriere, honestly, I don't have it set up yet, going to get it done soon. Since I don't have much experience with it, what other aspects can poudriere help test in case of rust-nightly as compared to regular build in ports tree?
This port is not required by any other port.
Build in the ports tree succeeded, + make package.

In the meantime will get poudriere set up and test the build.

Thank you.
Comment 3 oleksii.tsai 2016-01-11 00:48:17 UTC 
Created attachment 165379 [details]
Patch with port updates. Fixed.
Comment 4 oleksii.tsai 2016-01-11 00:48:52 UTC 
Created attachment 165380 [details]
Poudriere log
Comment 5 oleksii.tsai 2016-01-11 00:50:43 UTC 
Created attachment 165381 [details]
Poudriere build log
Comment 6 oleksii.tsai 2016-01-11 00:52:41 UTC 
I decided to fix portlint warnings. Uploaded an updated patch. Also did a poudriere build.
Poudriere configuration:
- Jail for 10.2-RELEASE
- Ports revision 405748 with proposed patch applied.
Comment 7 oleksii.tsai 2016-03-05 17:33:05 UTC 
This patch is no longer relevant, as rust 1.7.0 stable just landed in ports.
Comment 8 commit-hook freebsd_committer freebsd_triage 2016-03-29 18:00:05 UTC 
A commit references this bug:

Author: dumbbell
Date: Tue Mar 29 17:58:59 UTC 2016
New revision: 412126
URL: https://svnweb.freebsd.org/changeset/ports/412126

Log:
  lang/rust-nightly: Update to 1.9.0.20160318

  While here, relevant improvements made to lang/rust were copied.

  PR:		204418, 206091
  Reviewed by:	asomers, jbeich
  Approved by:	asomers, jbeich
  Differential Revision:	https://reviews.freebsd.org/D5766

Changes:
  head/lang/rust-nightly/Makefile
  head/lang/rust-nightly/distinfo
  head/lang/rust-nightly/pkg-plist