Bug 206480 - www/chromium: camera and mic not detected for use in WebRTC
Summary: www/chromium: camera and mic not detected for use in WebRTC
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: freebsd-chromium (Nobody)
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-01-22 02:31 UTC by Betso
Modified: 2016-06-08 19:12 UTC (History)
7 users (show)

See Also:
bugzilla: maintainer-feedback? (chromium)


Attachments
Chromium Media Settings Menu (15.67 KB, image/png)
2016-01-22 02:31 UTC, Betso
no flags Details
mic fix, v0 (3.02 KB, patch)
2016-05-06 18:33 UTC, Jan Beich
jbeich: maintainer-approval? (chromium)
Details | Diff
mic fix, v0 (screenshot) (20.73 KB, image/png)
2016-05-06 18:47 UTC, Jan Beich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Betso 2016-01-22 02:31:32 UTC
Created attachment 165931 [details]
Chromium Media Settings Menu

I am unable to use any of the WebRTC services which I have tried with Chromium.
https://appear.in and https://meet.jit.si are some to mention few. There are several other ones which I have tried with the same result: camera and microphone were not found.

Chromium doesn't seem to find camera listing:
Microphone: None available
Camera: "fake_device_0" 

There is no output in xterm (where chromium was started from) and no entry in the system logs (/var/log/messages).

I just filed bug #206479 regarding firefox where https://appear.in is currently working with my system.

Versions:
FreeBSD: 10.2-RELEASE
Chromium: 47.0.2526.106 (64-bit)

Thank you for your support!
Comment 1 Conrad Meyer freebsd_committer freebsd_triage 2016-04-07 17:48:26 UTC
Same here.
Comment 2 Jan Beich freebsd_committer freebsd_triage 2016-05-06 18:33:17 UTC
Created attachment 170053 [details]
mic fix, v0

More of the same as Firefox: snd_card_next() doesn't work with ALSA plugins. Regressed by https://codereview.chromium.org/7888011/
Comment 3 Jan Beich freebsd_committer freebsd_triage 2016-05-06 18:47:08 UTC
Created attachment 170055 [details]
mic fix, v0 (screenshot)
Comment 4 Jan Beich freebsd_committer freebsd_triage 2016-05-07 06:59:23 UTC
My |poudriere bulk -tj 101i386| build went fine[1]. Also tested runtime inside jail.

[1] http://sprunge.us/eANI
Comment 5 Jan Beich freebsd_committer freebsd_triage 2016-05-19 16:24:19 UTC
No feedback? I'll land per maintainer timeout tomorrow.
Comment 6 Conrad Meyer freebsd_committer freebsd_triage 2016-05-19 16:40:52 UTC
Looks fine to me, commit it.
Comment 7 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2016-05-20 05:59:01 UTC
Doesn't look too complicated, but I'm traveling right now and do not have time nor hardware for testing, but limited network access...
Comment 8 commit-hook freebsd_committer freebsd_triage 2016-05-20 18:40:25 UTC
A commit references this bug:

Author: jbeich
Date: Fri May 20 18:39:37 UTC 2016
New revision: 415570
URL: https://svnweb.freebsd.org/changeset/ports/415570

Log:
  www/chromium: unbreak WebRTC microphone selection with PULSEAUDIO=off

  Similar to r414386. No kernel ALSA is available to enumerate soundcards,
  so assume sound(4) can always be used via ALSA plugins like "oss".
  This partially reverts https://codereview.chromium.org/7888011/

  PR:		206480
  Reported by:	Betso <betso.net@gmail.com>
  Reviewed by:	cem, cmt (briefly)
  Approved by:	maintainer timeout (2 weeks)
  MFH:		2016Q2

Changes:
  head/www/chromium/Makefile
  head/www/chromium/files/patch-media__audio__alsa__audio_manager_alsa.cc
Comment 9 Jan Beich freebsd_committer freebsd_triage 2016-05-20 19:28:32 UTC
Getting upstream feedback is left to whoever has a Google Account.
Comment 10 commit-hook freebsd_committer freebsd_triage 2016-05-20 20:59:45 UTC
A commit references this bug:

Author: jbeich
Date: Fri May 20 20:58:56 UTC 2016
New revision: 415577
URL: https://svnweb.freebsd.org/changeset/ports/415577

Log:
  MFH: r415570

  www/chromium: unbreak WebRTC microphone selection with PULSEAUDIO=off

  Similar to r414386. No kernel ALSA is available to enumerate soundcards,
  so assume sound(4) can always be used via ALSA plugins like "oss".
  This partially reverts https://codereview.chromium.org/7888011/

  PR:		206480
  Reported by:	Betso <betso.net@gmail.com>
  Reviewed by:	cem, cmt (briefly)
  Approved by:	maintainer timeout (2 weeks)
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2016Q2/
  branches/2016Q2/www/chromium/Makefile
  branches/2016Q2/www/chromium/files/patch-media__audio__alsa__audio_manager_alsa.cc
Comment 11 Jan Beich freebsd_committer freebsd_triage 2016-06-07 21:23:44 UTC
ports r416521 backed out ports r415577 without an explanation. Likely the result of error prone merge workflow e.g., not using |git rebase| + |git svn dcommit|.

Leaving re-landing the fix to chromium@ folks.
Comment 12 Conrad Meyer freebsd_committer freebsd_triage 2016-06-07 21:27:28 UTC
CCing rene, who (accidentally?) reverted this.
Comment 13 Rene Ladan freebsd_committer freebsd_triage 2016-06-08 05:54:49 UTC
Yes, testing a re-fix.
Comment 14 commit-hook freebsd_committer freebsd_triage 2016-06-08 19:06:13 UTC
A commit references this bug:

Author: rene
Date: Wed Jun  8 19:06:05 UTC 2016
New revision: 416561
URL: https://svnweb.freebsd.org/changeset/ports/416561

Log:
  www/chromium: restore WebRTC audio via ALSA which got lost in last commit.

  PR:		206480
  Submitted by:	betso.net@gmail.com
  MFH:		2016Q2

Changes:
  head/www/chromium/Makefile
  head/www/chromium/files/patch-media__audio__alsa__audio_manager_alsa.cc
Comment 15 commit-hook freebsd_committer freebsd_triage 2016-06-08 19:12:16 UTC
A commit references this bug:

Author: rene
Date: Wed Jun  8 19:12:08 UTC 2016
New revision: 416562
URL: https://svnweb.freebsd.org/changeset/ports/416562

Log:
  MFH: r416561

  www/chromium: restore WebRTC audio via ALSA which got lost in last commit.

  PR:		206480
  Submitted by:	betso.net@gmail.com

  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2016Q2/
  branches/2016Q2/www/chromium/Makefile
  branches/2016Q2/www/chromium/files/patch-media__audio__alsa__audio_manager_alsa.cc