Bug 206645 - dns/py-py3dns: Limit to Python 3.x only
Summary: dns/py-py3dns: Limit to Python 3.x only
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Sunpoet Po-Chuan Hsieh
URL: https://reviews.freebsd.org/D5083
Keywords: patch
Depends on: 206643
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-26 13:22 UTC by Kubilay Kocak
Modified: 2016-02-02 15:38 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)
koobs: merge-quarterly+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kubilay Kocak freebsd_committer freebsd_triage 2016-01-26 13:22:49 UTC
dns/py-py3dns is a Python 3.x *only* package, but the port does not
currently [2] limit itself to USES=python:3.0+.

This results in errors for all dependent ports of py-pyspf, which was
reported for mail/postfix-policyd-spf-python (See bug 206643)

I'll add a review shortly for reference, but all changes come under blanket approval
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-26 13:24:14 UTC
Oops, it depends on bug 206643, not blocks.Can't update this port without updating py-pyspf first.
Comment 2 commit-hook freebsd_committer 2016-01-26 14:26:16 UTC
A commit references this bug:

Author: koobs
Date: Tue Jan 26 14:26:02 UTC 2016
New revision: 407274
URL: https://svnweb.freebsd.org/changeset/ports/407274

Log:
  dns/py-py3dns: Limit to Python 3.x, Fix dependencies

  py-py3dns is a Python 3.x only package, so limit USES=python
  accordingly. ipaddr is needed on <= 3.2, so add it as a conditional
  RUN_DEPENDS.

  While I'm here:

  - Add NO_ARCH
  - Add test target, TEST_DEPENDS and patch outdated unit test assertions
    that test against live domains, not mocked responses.
  - Remove unnecessary setup.py patch
  - Match COMMENT to setup.py:description
  - Sort and group USE{S} entries

  PR:			206645
  Reported by:		danger
  Approved by:		portmgr (blanket)
  MFH:			2016Q1
  Differential Revision:	D5083

Changes:
  head/dns/py-py3dns/Makefile
  head/dns/py-py3dns/files/patch-DNS-Base.py
  head/dns/py-py3dns/files/patch-DNS_tests_test__base.py
Comment 3 commit-hook freebsd_committer 2016-02-02 15:09:33 UTC
A commit references this bug:

Author: koobs
Date: Tue Feb  2 15:09:00 UTC 2016
New revision: 407821
URL: https://svnweb.freebsd.org/changeset/ports/407821

Log:
  MFH: r407274 dns/py-py3dns: Limit to Python 3.x, Fix dependencies

  py-py3dns is a Python 3.x only package, so limit USES=python
  accordingly. ipaddr is needed on <= 3.2, so add it as a conditional
  RUN_DEPENDS.

  While I'm here:

  - Add NO_ARCH
  - Add test target, TEST_DEPENDS and patch outdated unit test assertions
    that test against live domains, not mocked responses.
  - Remove unnecessary setup.py patch
  - Match COMMENT to setup.py:description
  - Sort and group USE{S} entries

  PR:			206645
  Reported by:		danger
  Approved by:		portmgr (blanket)
  Differential Revision:	D5083

  Approved by:		ports-secteam (feld)

Changes:
_U  branches/2016Q1/
  branches/2016Q1/dns/py-py3dns/Makefile
  branches/2016Q1/dns/py-py3dns/files/patch-DNS-Base.py
  branches/2016Q1/dns/py-py3dns/files/patch-DNS_tests_test__base.py