Created attachment 166355 [details] Unified diff Add a configuration option for Lumina desktop. Add lagg interface option for wifi users. Make fdesc mount mandatory in case bash or openjdk installed later. Improve removable media mount config for XFCE. Other minor enhancements and bug fixes.
Maintainer informed via mail
Thanks Jason Could you also: * Confirm this change passes QA (poudriere, portlint) * Update your bugzilla account email to match the port MAINTAINER address so you can set maintainer approval on the attachment Thanks!
I don't have a working Poudriere installation at the moment, but I run portlint -A immediately before submitting every PR and I have DEVELOPER=yes on every machine I use for development. I'm hoping to get Poudriere working shortly and intend to attach a log to all future PRs. I'm stumped on the email issue. I changed it the day 204755 was committed, but it apparently didn't stick. I just tried to change it again.
(In reply to Jason Bacon from comment #3) > I don't have a working Poudriere installation at the moment, but I run > portlint -A immediately before submitting every PR and I have DEVELOPER=yes > on every machine I use for development. > > I'm hoping to get Poudriere working shortly and intend to attach a log to > all future PRs. > > I'm stumped on the email issue. I changed it the day 204755 was committed, > but it apparently didn't stick. I just tried to change it again. Jason, FWIW there are also a couple of other options available; Having DEVELOPER=yes also allows you to *test* the entire process from anywhere on your system. For example, I do everything in ~/DEV for example, to test changes to sysutils/jailutils mkdir -p ~/DEV/sysutils/jailutils/SVN cd ~/DEV/sysutils/jailutils/SVN $ svn co --depth empty svn://svn.freebsd.org/ports/head 2016-01-31 $ svn up --set-depth empty 2016-01-31/sysutils $ svn up 2016-01-27/sysutils/jailutils EDIT files in 2016-01-27/sysutils/jailutils then perform $ script ~/DEV/sysutils-jailutils-QA $ make -DBATCH check-plist $ make stage-qa $ make check-sanity $ portlint -AC $ uname -a $ exit The only side-affect doing this, is that the ports framework will complain that it won't check category, because it knows it's not working within a complete ports tree. Another option that works quite nicely, and is dead simple to setup, is ports-mgmt/synth It produces QA LOGS very similar to those produced by Poudriere --Chris
Thanks for the tips! I got my poudriere installation working, though. It wasn't that hard - just needed to find the time to debug it. I also scripted a poudriere setup wizard to easily create a typical jail for ports testing. And BTW, I forgot to mention that this update depends on PR 206797 in case anyone didn't catch that.
Created attachment 166475 [details] Poudriere log
Comment on attachment 166475 [details] Poudriere log No need for approvals on logs
A commit references this bug: Author: rakuco Date: Wed Feb 17 12:25:10 UTC 2016 New revision: 409041 URL: https://svnweb.freebsd.org/changeset/ports/409041 Log: Update to 0.5.0. - Add a configuration option for Lumina desktop. - Add lagg interface option for wifi users. - Make fdesc mount mandatory in case bash or openjdk installed later. - Improve removable media mount config for XFCE. - Other minor enhancements and bug fixes. PR: 206798 Submitted by: Jason Bacon <bacon4000@gmail.com> (maintainer) Changes: head/sysutils/desktop-installer/Makefile head/sysutils/desktop-installer/distinfo head/sysutils/desktop-installer/pkg-plist
Committed, thanks!