Created attachment 166543 [details] patch for audio/audacity Change to use autoreconf and libtool. Add and remove patches for it.
Created attachment 166544 [details] test log on 9.3-STABLE amd64 It needs test more on environment below. 10.x Macintosh(darwin*) If it cannot build, this bug should be closed without change.
I'll test it out on 10 and 11.
Compiles and runs fine on 10 and 11, but I'm not sure what the benefit of this patch is. Is there a compelling reason to change the upstream's configs?
(In reply to xxjack12xx from comment #3) Thank you. lib-src/FileDialog sub directory always uses Objective-C++ linker for linking because *.mm file is appeared in lib-src/FileDialog/Makefile.am. So I divided it into lib-src/FileDialog/{gtk,mac,win}/Makefile.am and changed as *.la is built. Patching to *.in files is difficult if autoreconf is run.
Created attachment 166584 [details] Warnings I get this giant warning block, can this be suppressed?
Created attachment 166592 [details] patch for audio/audacity (In reply to xxjack12xx from comment #5) This is a patch for suppressing attachment 166584 [details]. files/patch-lib-src_portaudio-v19_bindings_cpp_configure.ac has been added.
Looks good, I was able to compile and run audacity in 10 and 11
Created attachment 166649 [details] log with attachment 166592 [details] on 9.3-STABLE amd64 Perhaps, these warnings have been grasped by originator.
Created attachment 166650 [details] additional patch if needed Or, autotools have been forgot by originator.
I think we should tell upstream to fix instead of changing it. attachment 166650 [details]
Created attachment 167341 [details] additional patch AM_SILENT_RULES([yes]) is added. Build log size become smaller (ex. 761486 Bytes). It can upload without compressing.
Created attachment 167896 [details] patch for audio/audacity update attachment 166592 [details] and merge attachment 167341 [details].
Created attachment 167897 [details] build log (with attachment 167896 [details])
New patch compiles fine on 11
Anyone noticed a build error when alsa (alsa-lib-1.1.0) gets autodetected since changes committed on March 5th? libtool: compile: cc -c -O2 -pipe -fno-strict-aliasing -march=athlon64-sse3 -DLIBICONV_PLUG -fstack-protector -DPA_LITTLE_ENDIAN -I./include -I./src/common -I./src/os/unix -pthread -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_SYS_SOUNDCARD_H=1 -DSIZEOF_SHORT=2 -DSIZEOF_INT=4 -DSIZEOF_LONG=8 -DHAVE_CLOCK_GETTIME=1 -DHAVE_NANOSLEEP=1 -DPA_USE_ALSA=1 -DPA_USE_OSS=1 src/hostapi/alsa/pa_linux_alsa.c -o src/hostapi/alsa/pa_linux_alsa.o src/hostapi/alsa/pa_linux_alsa.c:52:10: fatal error: 'alsa/asoundlib.h' file not found #include <alsa/asoundlib.h> ^ 1 error generated. Makefile:231: recipe for target 'src/hostapi/alsa/pa_linux_alsa.lo' failed
What OS version and what options did you use? I'm not able to reproduce on 11.
I have the same error on 10.2-RELEASE:
(In reply to Barbara Guida from comment #15) For the record / audit trail: alsa build issue is tracked via bug 207892
(In reply to xxjack12xx from comment #14) When all OPTIONs are deactivated, this build failure occurs: [...] ===> Configuring for audacity-2.1.2_3 Can't exec "autopoint": No such file or directory at /usr/local/share/autoconf-2.69/Autom4te/FileUtils.pm line 345. autoreconf-2.69: failed to run autopoint: No such file or directory autoreconf-2.69: autopoint is needed because this package uses Gettext *** Error code 1 Stop. make: stopped in /usr/ports/audio/audacity Could you double-check the latest patch?
Created attachment 168069 [details] fix problem of comment #19 Bug 197200 was same problem. I did it as a reference.
(In reply to Tatsuki Makino from comment #20) Confirmed that attachment 168069 [details] resolves the build issue. If maintainer approves, I can commit this alongside the fix for bug 207074.
Comment on attachment 168069 [details] fix problem of comment #19 Request maintainer approval for this patch.
I will check it out.
Created attachment 168272 [details] Compile error I am getting a compilation error on FreeBSD 11 with alsa checked.
Sorry, I mean't with alsa unchecked. Happens on FreeBSD 10 and 11
Commented on the wrong thread, commends should be referring to 207892
This patch looks ok
Actually, I am getting a plist error: ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: %%DATADIR%%/include/audacity/ConfigInterface.h Error: Orphaned: %%DATADIR%%/include/audacity/EffectAutomationParameters.h Error: Orphaned: %%DATADIR%%/include/audacity/EffectInterface.h Error: Orphaned: %%DATADIR%%/include/audacity/IdentInterface.h Error: Orphaned: %%DATADIR%%/include/audacity/ImporterInterface.h Error: Orphaned: %%DATADIR%%/include/audacity/ModuleInterface.h Error: Orphaned: %%DATADIR%%/include/audacity/PluginInterface.h Error: Orphaned: %%DATADIR%%/include/audacity/Types.h ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: include/audacity/ConfigInterface.h Error: Missing: include/audacity/EffectAutomationParameters.h Error: Missing: include/audacity/EffectInterface.h Error: Missing: include/audacity/IdentInterface.h Error: Missing: include/audacity/ImporterInterface.h Error: Missing: include/audacity/ModuleInterface.h Error: Missing: include/audacity/PluginInterface.h Error: Missing: include/audacity/Types.h Error: Missing: %%DATADIR%%/include/audacity ===> Error: Plist issues found. *** Error code 1
(In reply to xxjack12xx from comment #28) Perhaps, patch-Makefile.am, patch-configure.ac and patch-include_Makefile.am of attachment 166826 [details] are existed in your audio/audacity/files directory. Would you retry the order below? 1. revert audio/audacity directory. 2. patch attachment 168069 [details] for checking bug 206914. 3. patch attachment 166826 [details] for checking bug 207074.
Ok, testing now.
Patches look good. I did a clean patch and build with all the options checked/unchecked and compiles fine on 11.
A commit references this bug: Author: riggs Date: Fri Mar 18 06:51:29 UTC 2016 New revision: 411331 URL: https://svnweb.freebsd.org/changeset/ports/411331 Log: Add autoreconf libtool to USES; install headers to include, not DATADIR This changeset brings in the necessary fixes in audacity's build system to use autoreconf and libtool in USES. (206914) First use case of this is to have audacity install its headers in the standard include path rather than DATADIR (207074). Bump PORTREVISION. PR: 206914, 207074 Submitted by: tatsuki_makino@hotmail.com Approved by: xxjack12xx@gmail.com (maintainer) Changes: head/audio/audacity/Makefile head/audio/audacity/files/patch-Makefile.am head/audio/audacity/files/patch-configure.ac head/audio/audacity/files/patch-include_Makefile.am head/audio/audacity/files/patch-lib-src_FileDialog_Makefile.am head/audio/audacity/files/patch-lib-src_FileDialog_Makefile.in head/audio/audacity/files/patch-lib-src_FileDialog_configure.ac head/audio/audacity/files/patch-lib-src_FileDialog_gtk_Makefile.am head/audio/audacity/files/patch-lib-src_FileDialog_mac_Makefile.am head/audio/audacity/files/patch-lib-src_FileDialog_win_Makefile.am head/audio/audacity/files/patch-lib-src__libmad__configure head/audio/audacity/files/patch-lib-src__soundtouch__source__SoundTouch__Makefile.in head/audio/audacity/files/patch-lib-src_libmad_configure.ac head/audio/audacity/files/patch-lib-src_libnyquist_Makefile.in head/audio/audacity/files/patch-lib-src_portaudio-v19_bindings_cpp_configure.ac head/audio/audacity/files/patch-lib-src_portmixer_configure head/audio/audacity/files/patch-src_Makefile.am head/audio/audacity/files/patch-src__Makefile.in head/audio/audacity/pkg-plist
(In reply to Tatsuki Makino from comment #20) Since these changes are quite substantial, could you try to get this upstream? Maintaining this kind of patch over a long time would quite cumbersome for maintainers.
Thank you very much. (In reply to Thomas Zander from comment #33) I concur with you on that point. I will report them to upstream.