Bug 207479 - Makefile assumes existence of svn instead of using svnlite from base
Summary: Makefile assumes existence of svn instead of using svnlite from base
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Port Management Team
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-02-25 10:44 UTC by Torsten Zühlsdorff
Modified: 2016-04-13 02:15 UTC (History)
3 users (show)

See Also:


Attachments
patch against /usr/ports/Makefile (556 bytes, patch)
2016-02-25 10:44 UTC, Torsten Zühlsdorff
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Zühlsdorff 2016-02-25 10:44:03 UTC
Created attachment 167392 [details]
patch against /usr/ports/Makefile

Hello,

like raised on the mailinglist:
https://lists.freebsd.org/pipermail/freebsd-ports/2016-February/102245.html

There is an issue when trying to perform:
$ make -C /usr/ports update
on an SVN repository in case there is no svn installed.

The freebsd base ships svnlite, which could be used, even if no svn is installed. Provided a patch which makes this default.

While writing i'm not sure if FreeBSD 9.3 is already shipped with svnlite. I could not find something about this, so this clearly must be checked before commit. 

Greetings,
Torsten
Comment 1 Chris Hutchinson 2016-02-25 15:56:23 UTC
(In reply to Torsten Zühlsdorff from comment #0)
> Created attachment 167392 [details]
> patch against /usr/ports/Makefile
> 
> Hello,
> 
> like raised on the mailinglist:
> https://lists.freebsd.org/pipermail/freebsd-ports/2016-February/102245.html
> 
> While writing i'm not sure if FreeBSD 9.3 is already shipped with svnlite. I
> could not find something about this, so this clearly must be checked before
> commit. 
Hello, Torsten. Good catch!
For the record; I can confirm that 9.(ANY) does *not* ship with svnlite.
Just so you know, :)

--Chris
> 
> Greetings,
> Torsten
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-04-13 02:03:46 UTC
A commit references this bug:

Author: swills
Date: Wed Apr 13 02:02:44 UTC 2016
New revision: 413169
URL: https://svnweb.freebsd.org/changeset/ports/413169

Log:
  Try harder to find svn

  Don't assume svn is installed, but use it if it's available, falling back to
  svnlite if not (or using svn from base in the case where WITH_SVN was set in
  base). This matches the logic in base for finding svn.

  PR:		207479
  Discussed with:	gjb
  Reported by:	Torsten Z?hlsdorff <ports@toco-domains.de>

Changes:
  head/Makefile
Comment 3 Steve Wills freebsd_committer freebsd_triage 2016-04-13 02:15:10 UTC
Isn't quite as simple as that patch, but should be fixed now. Thanks for the report!