Bug 207541 - mail/mimedefang doesn't package when DOCS and EXAMPLES are unset
Summary: mail/mimedefang doesn't package when DOCS and EXAMPLES are unset
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-27 12:49 UTC by Stewart Morgan
Modified: 2016-03-28 02:04 UTC (History)
1 user (show)

See Also:
m.tsatsenko: maintainer-feedback-


Attachments
Patch to fix pkg-plist (594 bytes, patch)
2016-02-27 12:49 UTC, Stewart Morgan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stewart Morgan 2016-02-27 12:49:55 UTC
Created attachment 167477 [details]
Patch to fix pkg-plist

Hello,

Building the port with "OPTIONS_UNSET+= DOCS EXAMPLES" fails at the package stage because the %%PORTDOCS%% and %%PORTEXAMPLES%% macros are the wrong side of the @dir directive.

The attached patch puts them in the right place and the port succeeds for me.

Thanks,

Stewart.
Comment 1 m.tsatsenko 2016-03-06 22:27:38 UTC
Hello,
Thanks for reporting this. 
But as far I can see those @dir lines are not required at all and can be removed safely.
Comment 2 Stewart Morgan 2016-03-10 04:40:46 UTC
Hello,

From my understanding[*], any directory that is created in the port Makefile (which both DOCSDIR and EXAMPLESDIR are) should be added to the pkg-plist file for removal upon package deinstallation...?

[*]:https://www.freebsd.org/doc/en/books/porters-handbook/plist-cleaning.html
Comment 3 m.tsatsenko 2016-03-10 07:52:55 UTC
Hello.
Above applies to empty directories only.
In our case the directories are not empty and handled by pkg automatically.
Comment 4 Stewart Morgan 2016-03-13 12:23:15 UTC
Hello,
Ah yes, re-reading the Makefile that does appear to be the case! :)
Please remove them as you intended!
Thanks.
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-03-28 02:04:44 UTC
A commit references this bug:

Author: amdmi3
Date: Mon Mar 28 02:03:47 UTC 2016
New revision: 412027
URL: https://svnweb.freebsd.org/changeset/ports/412027

Log:
  - Fix plist issue which leads to packaging failure with disabled DOCS or EXAMPLES

  PR:		207541
  Submitted by:	stewart.morgan@gmail.com
  Approved by:	m.tsatsenko@gmail.com (maintainer)

Changes:
  head/mail/mimedefang/pkg-plist