Bug 207550 - net-p2p/retroshare: Update to 0.6.0
Summary: net-p2p/retroshare: Update to 0.6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kurt Jaeger
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2016-02-28 05:20 UTC by w.schwarzenfeld
Modified: 2016-05-27 18:44 UTC (History)
6 users (show)

See Also:
peter: maintainer-feedback+

Attachments
svn-diff_net-p2p_retroshare (474 bytes, patch)
2016-02-28 05:20 UTC, w.schwarzenfeld 		no flags Details | Diff
portlint-retroshare (1.82 KB, text/plain)
2016-02-28 05:22 UTC, w.schwarzenfeld 		no flags Details
svn-diff_net-p2p_retroshare (1.28 KB, patch)
2016-02-28 05:38 UTC, w.schwarzenfeld 		no flags Details | Diff
svn-diff_net-p2p_retroshare (1.20 KB, patch)
2016-02-28 05:47 UTC, w.schwarzenfeld 		peter: maintainer-approval+
Details | Diff
poudriere-retroshare-0.6.0.log (905.24 KB, text/x-log)
2016-02-28 07:12 UTC, w.schwarzenfeld 		no flags Details
Update to 0.6.0 (56.74 KB, patch)
2016-03-06 00:15 UTC, peter 		peter: maintainer-approval+
Details | Diff
build failure log (267.42 KB, text/plain)
2016-03-15 15:57 UTC, Mark Felder 		no flags Details
new patch with pkgconfig (56.75 KB, patch)
2016-03-15 19:49 UTC, peter 		peter: maintainer-approval+
Details | Diff
build failure log (642.79 KB, text/plain)
2016-03-15 20:42 UTC, Mark Felder 		no flags Details
DateTime.h time.h fix (57.31 KB, patch)
2016-03-15 22:00 UTC, peter 		no flags Details | Diff
Update to 0.6.0; now even on FreeBSD 10.1 (58.01 KB, patch)
2016-03-22 21:27 UTC, peter 		peter: maintainer-approval+
Details | Diff
Updated patch 0.6.0 (65.47 KB, patch)
2016-05-20 07:55 UTC, Yuri Victorovich 		no flags Details | Diff
Show Obsolete (10) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description w.schwarzenfeld 2016-02-28 05:20:31 UTC 
Created attachment 167494 [details]
svn-diff_net-p2p_retroshare

I do it cause of a request in FreeBSD-Forums.

No real ChangeLog found, but release notes: 
https://retroshareteam.wordpress.com/
Comment 1 w.schwarzenfeld 2016-02-28 05:22:28 UTC 
Created attachment 167495 [details]
portlint-retroshare
Comment 2 w.schwarzenfeld 2016-02-28 05:38:28 UTC 
Created attachment 167497 [details]
svn-diff_net-p2p_retroshare

Correct pkg-plist.
Comment 3 w.schwarzenfeld 2016-02-28 05:47:53 UTC 
Created attachment 167498 [details]
svn-diff_net-p2p_retroshare

Again, correct pkg-plist.
Comment 4 w.schwarzenfeld 2016-02-28 07:12:58 UTC 
Created attachment 167501 [details]
poudriere-retroshare-0.6.0.log
Comment 5 peter 2016-03-04 09:33:04 UTC 
Tanks for the patch, poudriere log looks good!
Unfortunately, due to a HD crash my development machines and patches are gone, so at the moment I can not test the patch. Otherwise approved.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2016-03-04 09:36:52 UTC 
@Peter, you can accept/approve a patch by setting maintainer-approval to + on attachments for ports you are maintainer of.

This can be done via Attachment -> Details -> maintainer-approval [+]

Thanks!
Comment 7 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-03-04 15:50:02 UTC 
The patch looks incomplete; distfile has not been changed and 0.6.0/retroshare_0.5.5-0.7068.tar.gz does not exist in SourceForge. In fact, the project's page suggests new releases are actually hosted on GitHub (which possibly allows you to get rid of all the SRC_REVISION/SRC_VERSION hackery).

While here: the QT_BINDIR change in pkg-plist looks unnecessary.
Comment 8 w.schwarzenfeld 2016-03-04 16:10:31 UTC 
Sorry, but I seems all was wrong. Retroshare-0.6.0 is rc-2. So I close the PR.
Comment 9 peter 2016-03-06 00:15:40 UTC 
Created attachment 167753 [details]
Update to 0.6.0

RetroShare 0.6.0 is considered final https://retroshareteam.wordpress.com/2016/02/07/release-notes-for-final-0-6-0/
This is a patch against a current retroshare in net-p2p
Tested only on my local virtualbox machine, I would be glad if someone could run this through a poudriere setup
Comment 10 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-03-06 13:28:52 UTC 
Reopening after comment #9.
Comment 11 Mark Felder freebsd_committer freebsd_triage 2016-03-15 13:13:21 UTC 
I'm seeing this error:

/usr/local/include/gnome-keyring-1/gnome-keyring.h:27:10: fatal error: 'glib.h' file not found
#include <glib.h>
         ^
1 error generated.
*** [rsloginhandler.o] Error code 1


glib.h is already on the system because USE_GNOME=glib20, so it must be missing from an include path or something
Comment 12 peter 2016-03-15 15:46:27 UTC 
(In reply to Mark Felder from comment #11)
Thanks! I will look into that. Can you paste the full build output somewhere or at least give the subdirectory (libretroshare, retroshare-gui, plugins, ...) where the build fails?
Comment 13 Mark Felder freebsd_committer freebsd_triage 2016-03-15 15:57:21 UTC 
Created attachment 168241 [details]
build failure log

Here you go
Comment 14 peter 2016-03-15 19:49:35 UTC 
Created attachment 168254 [details]
new patch with pkgconfig

Thanks! USES pkgconfig got missing, sorry for the mess. Attached a new diff, or just add pkgconfig to USES=
Comment 15 Mark Felder freebsd_committer freebsd_triage 2016-03-15 20:42:58 UTC 
Created attachment 168255 [details]
build failure log

New build error now
Comment 16 peter 2016-03-15 22:00:47 UTC 
Created attachment 168270 [details]
DateTime.h time.h fix

Somehow on my system (10.2-RELEASE) time.h or sys/types.h gets included, but not on your build machine..
To be honest, the missing time_t could happen also in other places of the code, retroshare makes plenty use of time_t. I'm not really convinced this will build now :-)
If you could be so kind and further try these patch(es), I will be happy to provide them.
Comment 17 Mark Felder freebsd_committer freebsd_triage 2016-03-16 19:23:23 UTC 
I am still getting a build error with this latest patch. Do you have a poudriere build environment to help reproduce the issue?
Comment 18 peter 2016-03-17 18:18:55 UTC 
(In reply to Mark Felder from comment #17)
Trying to build with a poudriere 3.1.1 and FreeBSD 10.1-p12 (afaik) jail. Will take some time to build all the packages. Hopefully i can reproduce the error.
Comment 19 peter 2016-03-22 21:27:23 UTC 
Created attachment 168514 [details]
Update to 0.6.0; now even on FreeBSD 10.1

Attached new patch, fixes builds on FreeBSD 10.1
poudriere testport approved.
Could you please confirm that this works on your system?
Comment 20 Yuri Victorovich freebsd_committer freebsd_triage 2016-05-20 07:55:44 UTC 
Created attachment 170500 [details]
Updated patch 0.6.0

Previous patch didn't apply cleanly, and was also missing some LIB_DEPENDS and USES.

However, the resulting executable runs but doesn't connect to the network. Not sure what the problem is.
Comment 21 peter 2016-05-20 13:30:53 UTC 
Comment on attachment 170500 [details]
Updated patch 0.6.0

Patch works on latest ports, compiled on FreeBSD-10.2 and was able to connect to test chatserver. Checked network with wireshark. Could also connect to DHT.
Approved. Thanks for your work Yuri.
Comment 22 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-20 19:20:16 UTC 
testbuilds@work
Comment 23 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-20 19:22:09 UTC 
btw, fails to build on 11-amd64 host with some ports already installed.
Comment 24 Yuri Victorovich freebsd_committer freebsd_triage 2016-05-20 23:06:42 UTC 
Kurt,

Could you post the error message?

Thanks!
Comment 25 Yuri Victorovich freebsd_committer freebsd_triage 2016-05-21 01:18:02 UTC 
I have just built retroshare in 11-amd64 fine.
Comment 26 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-21 01:29:26 UTC 
Re-tried, it now builds. Sorry 8-(
Comment 27 Yuri Victorovich freebsd_committer freebsd_triage 2016-05-21 01:34:52 UTC 
No problem!
Comment 28 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-21 02:07:08 UTC 
Testbuilds are fine.
Comment 29 commit-hook freebsd_committer freebsd_triage 2016-05-21 02:11:07 UTC 
A commit references this bug:

Author: pi
Date: Sat May 21 02:11:01 UTC 2016
New revision: 415583
URL: https://svnweb.freebsd.org/changeset/ports/415583

Log:
  net-p2p/retroshare: 0.5.5c -> 0.6.0

  Changes:
   https://retroshareteam.wordpress.com/2016/02/07/release-notes-for-final-0-6-0/
  - distsite moved to github

  PR:		207550
  Submitted by:	w.schwarzenfeld@aon.at, Yuri Victorovich <yuri@rawbw.com>, peter@netkey.at (maintainer)
  Reviewed by:	feld

Changes:
  head/net-p2p/retroshare/Makefile
  head/net-p2p/retroshare/distinfo
  head/net-p2p/retroshare/files/patch-clang
  head/net-p2p/retroshare/files/patch-libbitdht-src-libbitdht.pro
  head/net-p2p/retroshare/files/patch-libbitdht_src_bitdht_bencode.c
  head/net-p2p/retroshare/files/patch-libretroshare-src-libretroshare.pro
  head/net-p2p/retroshare/files/patch-libretroshare_src_grouter_p3grouter.h
  head/net-p2p/retroshare/files/patch-libretroshare_src_libretroshare.pro
  head/net-p2p/retroshare/files/patch-libretroshare_src_rsserver_rsinit.cc
  head/net-p2p/retroshare/files/patch-libretroshare_src_util_argstream.h
  head/net-p2p/retroshare/files/patch-plugins-FeedReader-FeedReader.pro
  head/net-p2p/retroshare/files/patch-plugins_FeedReader_FeedReader.pro
  head/net-p2p/retroshare/files/patch-plugins_FeedReader_interface_rsFeedReader.h
  head/net-p2p/retroshare/files/patch-plugins_VOIP_VOIP.pro
  head/net-p2p/retroshare/files/patch-plugins_VOIP_gui_VideoProcessor.cpp
  head/net-p2p/retroshare/files/patch-retroshare-gui__src__retroshare-gui.pro
  head/net-p2p/retroshare/files/patch-retroshare-gui_src_retroshare-gui.pro
  head/net-p2p/retroshare/files/patch-retroshare-gui_src_util_DateTime.h
  head/net-p2p/retroshare/files/patch-retroshare-gui_src_util_RsNetUtil.cpp
  head/net-p2p/retroshare/files/patch-retroshare-nogui__src__retroshare-nogui.pro
  head/net-p2p/retroshare/files/patch-retroshare-nogui_src_retroshare-nogui.pro
  head/net-p2p/retroshare/files/patch-retroshare-nogui_src_retroshare.cc
  head/net-p2p/retroshare/files/patch-supportlibs__pegmarkdown__pegmarkdown.pro
  head/net-p2p/retroshare/pkg-descr
  head/net-p2p/retroshare/pkg-plist
Comment 30 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-21 02:16:27 UTC 
Committed, thanks!
Comment 31 commit-hook freebsd_committer freebsd_triage 2016-05-27 18:44:38 UTC 
A commit references this bug:

Author: pi
Date: Fri May 27 18:43:52 UTC 2016
New revision: 415956
URL: https://svnweb.freebsd.org/changeset/ports/415956

Log:
  net-p2p/retroshare: update WWW

  PR:		207550

Changes:
  head/net-p2p/retroshare/pkg-descr