Bug 207620 - sysutils/zxfer: zxfer crashes if a snapshot is deleted after it scans the pool
Summary: sysutils/zxfer: zxfer crashes if a snapshot is deleted after it scans the pool
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Allan Jude
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-01 16:27 UTC by dgilbert
Modified: 2022-07-06 15:10 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (ports)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dgilbert 2016-03-01 16:27:10 UTC
There's a problem or a basic conflict between sysutils/zxfer and sysutils/zfstools --- zfstools will happily make and delete snapshots on a schedule.  zxfer seems to crash if, after it scans the pool, a snapshot gets deleted.

It would be better if it re-read the pool configuration and then continued to work.
Comment 1 Allan Jude freebsd_committer 2016-03-01 19:15:13 UTC
I am looking at making it re-fetch the list of snapshots if the list it has is more than a minute or two old, but have not gotten around to implementing it.

I am planning a totally new tool to replace zxfer, because it fundamentally lacks the ability to handle things like resumable send and bookmarks.

Anyway, please file this upstream with the port here: https://github.com/allanjude/zxfer/issues/new
Comment 2 John Marino freebsd_committer 2016-08-19 03:59:05 UTC
Assign Allan his own PR.

(Maybe it's a good idea to change MAINTAINER to allanjude@FreeBSD.org on all ports maintained by ports@scaleengine.com ?)
Comment 3 John Marino freebsd_committer 2016-08-19 04:00:29 UTC
correction: PR was opened by dgilbert but it's still better to assign it to FreeBSD user name
Comment 4 Walter Schwarzenfeld freebsd_triage 2018-02-01 11:04:45 UTC
Any news here?
Comment 5 Allan Jude freebsd_committer 2018-02-07 04:16:54 UTC
This is still a known issue.
Comment 6 Sam 2022-07-06 05:20:16 UTC
For people coming to check the status of this issue:

This comment (2020) was quite important for my use-case:

> You should not create snapshots on the destination of the zfs replication.

https://github.com/allanjude/zxfer/issues/29#issuecomment-749574579
Comment 7 dgilbert 2022-07-06 15:10:57 UTC
(In reply to Sam from comment #6)

Yeah... you're not reading this correctly.  A good example is that you're running (say) sysutils/zfstools provided zfs-auto-snapshot.  Then you run a zxfer.  While zxfer is running, zfs-auto-snapshot runs on the source machine.

zxfer only looks for the synchronization list once when it starts.  zxfer also fails if a snapshot is deleted before it gets around to it.