Bug 207638 - sysutils/minimunin: cpu configuration
Summary: sysutils/minimunin: cpu configuration
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2016-03-02 09:57 UTC by Xavier Garcia
Modified: 2016-05-09 19:07 UTC (History)
2 users (show)

See Also:
erdgeist: maintainer-feedback+

Attachments
Patch that adds the missing white space (416 bytes, patch)
2016-03-02 09:57 UTC, Xavier Garcia 		rakuco: maintainer-approval? (erdgeist)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xavier Garcia 2016-03-02 09:57:41 UTC 
Created attachment 167629 [details]
Patch that adds the missing white space

There is a typo in the bash expression that extracts the clockrate from sysconfig because there is a white space missing.

Tested on FreeBSD 10 but not on FreeBSD 9.


As a result, the Munin master cannot evaluate the CDEF expression and fails to configure the CPU graphs.


Steps to reproduce the bug:

Notice the white space before 127

# echo "config cpu" | minimunin | grep cdef
system.cdef system, 127,/,100,*
interrupt.cdef interrupt, 127,/,100,*
user.cdef user, 127,/,100,*
nice.cdef nice, 127,/,100,*
idle.cdef idle, 127,/,100,*


Attached patch with the fix
Comment 1 erdgeist 2016-03-04 13:35:22 UTC 
Commited in

https://erdgeist.org/gitweb/minimunin/commit/?id=941288a85098c489a268d40adddd4751545d057e

Will roll new port version soon.

Thanks

 erdgeist
Comment 2 erdgeist 2016-03-17 23:34:21 UTC 
New port version submitted in bug #208105.