Bug 207822 - [revive port] irc/smuxi as it was removed previously
Summary: [revive port] irc/smuxi as it was removed previously
Status: Closed Not Enough Information
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: feature, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2016-03-08 21:57 UTC by FreeBSD smuxi
Modified: 2016-03-31 21:39 UTC (History)
1 user (show)

See Also:


Attachments
patch (26.82 KB, patch)
2016-03-08 21:57 UTC, FreeBSD smuxi
no flags Details | Diff
patch (24.60 KB, patch)
2016-03-20 21:48 UTC, FreeBSD smuxi
no flags Details | Diff
build log (323.10 KB, text/x-log)
2016-03-20 21:48 UTC, FreeBSD smuxi
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description FreeBSD smuxi 2016-03-08 21:57:39 UTC
Created attachment 167881 [details]
patch

This port was removed due to broken for 6+m, I recently started using it and I have been working with the main dev to get this back in the FreeBSD ports system.

This port is in reviews as https://reviews.freebsd.org/D5575

For some reason I got confused as was using reviews as the main means of submitting PR's.
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-03-13 12:40:33 UTC
This change failed `make check-plist':

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/pkgconfig/smuxi-common.pc
Error: Orphaned: lib/pkgconfig/smuxi-engine-irc.pc
Error: Orphaned: lib/pkgconfig/smuxi-engine.pc
Error: Orphaned: lib/pkgconfig/smuxi-frontend.pc
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: libdata/pkgconfig/smuxi-common.pc
Error: Missing: libdata/pkgconfig/smuxi-engine-irc.pc
Error: Missing: libdata/pkgconfig/smuxi-engine.pc
Error: Missing: libdata/pkgconfig/smuxi-frontend.pc

For new iterations of this patch, I suggest you provide a patch on top of the old port since we're going to svn cp it instead of adding a completely new port:

$ cd /path/to/ports/irc
$ svn cp ^/head/irc/smuxi@325482 .
$ # add your changes
$ svn diff > new-smuxi.patch
Comment 2 FreeBSD smuxi 2016-03-14 15:42:32 UTC
I will fix this later.
Comment 3 FreeBSD smuxi 2016-03-20 21:42:47 UTC
I am working on this now..
Comment 4 FreeBSD smuxi 2016-03-20 21:47:37 UTC
Done, please reply if I didn't do this correctly.
Comment 5 FreeBSD smuxi 2016-03-20 21:48:05 UTC
Created attachment 168437 [details]
patch

new patch
Comment 6 FreeBSD smuxi 2016-03-20 21:48:39 UTC
Created attachment 168438 [details]
build log

Build log for irc/smuxi
Comment 7 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-03-22 10:30:25 UTC
I see that the pkg-plist was updated and the .pc files are listed as installed under lib/pkgconfig. It should be the other way around: .pc files are installed under libdata/pkgconfig on FreeBSD, and smuxi needs to be adjusted to do that. This can probably be done with:

  USES=pathfix
  PATHFIX_MAKEFILEIN=Makefile.include

Additionally, the build log you've posted contains a suggestion you probably want to adopt:

> pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:10:amd64" -- no architecture specific files found:
> **** could this package use a wildcard architecture?
Meaning you could add NO_ARCH=yes to the Makefile.
Comment 8 FreeBSD smuxi 2016-03-22 20:13:15 UTC
I will fix this later today, thank you for suggestions.
Comment 9 FreeBSD smuxi 2016-03-27 03:57:11 UTC
I am unsure how to fix this, they use non std paths for pc file installs. and I don't wish to "hack it" to make it either install to the right place or not at all.
Comment 10 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-03-28 13:38:15 UTC
Using USES=pathfix (which essentially just performs some sed calls replacing lib/pkgconfig with libdata/pkgconfig in a number of ways for autotools-based ports) is totally fine, and I couldn't call it a hack: a lot of software just assumes the .pc files are installed into a certain location but the FreeBSD project chose install them into a different location.
Comment 11 FreeBSD smuxi 2016-03-31 21:39:23 UTC
No real help from commiters, so close