Bug 208069 - x11-wm/i3: i3-config-wizard generates incomplete config file
Summary: x11-wm/i3: i3-config-wizard generates incomplete config file
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-16 19:01 UTC by c.brinkhaus
Modified: 2018-02-28 11:59 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (bapt)


Attachments
New generated incomplete config file (1.81 KB, text/plain)
2016-03-16 19:01 UTC, c.brinkhaus
no flags Details
Old working config file (4.96 KB, text/plain)
2016-03-16 20:12 UTC, c.brinkhaus
no flags Details
[patch] Existing keysyms are translated - others are copied (2.02 KB, patch)
2016-03-20 17:34 UTC, c.brinkhaus
no flags Details | Diff
Working config generated with patch applied (5.14 KB, text/plain)
2016-03-20 17:39 UTC, c.brinkhaus
no flags Details
[patch] Existing keysyms are translated - others are copied - svndiff (2.67 KB, patch)
2016-03-20 18:57 UTC, c.brinkhaus
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description c.brinkhaus 2016-03-16 19:01:11 UTC
Created attachment 168304 [details]
New generated incomplete config file

Dear community,

i3-config-wizard is a tool of x11-wm/i3 to generate a default configuration file. The last lines of a newly generated file end with

# alternatively, you can use the cursor keys:
bindsym $mod+ISO_Level3_Shift focus left
bindsym $mod+Super_R focus down
bindsym $mod+Print focus up

As far as I remember previously generated files have had much more default lines. On https://forums.freebsd.org/threads/54290/#post-314824 problems about restarting i3 are reported.

An error message on my system is as below:
i3-config-wizard: xkb_keymap_key_get_syms_by_level returned no symbols for keycode 114
I am not sure if this is related to the problem or not.

Thank you for your kind consideration!

Kind regards,
Christoph Brinkhaus
Comment 1 c.brinkhaus 2016-03-16 20:12:11 UTC
Created attachment 168306 [details]
Old working config file
Comment 2 c.brinkhaus 2016-03-16 20:15:04 UTC
Dear Baptiste,

I have digged a little bit and compared the lines where the incomplete config ends with similar lines in an older configuration and in i3.config.keycodes.

i3.config.keycodes:
# alternatively, you can use the cursor keys:
bindcode $mod+Shift+113 move left
bindcode $mod+Shift+116 move down
bindcode $mod+Shift+111 move up
bindcode $mod+Shift+114 move right

working config
# alternatively, you can use the cursor keys:
bindsym $mod+ISO_Level3_Shift focus left
bindsym $mod+Super_R focus down
bindsym $mod+Print focus up
bindsym $mod+(null) focus right

Therefore I guess that a new version of i3-config-wizard might not catch the missing keycode. It seems to me that an older version replaced whe missing key by (null). The new version just stops at an undefined keymap entry.

Kind regards,
Christoph Brinkhaus
Comment 3 c.brinkhaus 2016-03-18 19:47:58 UTC
Please see https://github.com/i3/i3/issues/2141.
The behaviour has already been detected by the i3 community.
Comment 4 Baptiste Daroussin freebsd_committer 2016-03-19 17:21:04 UTC
Thanks very much for the report and sorry for the late reply.

I will have a look in a few days as I'm very busy now (sorry)
Comment 5 c.brinkhaus 2016-03-20 17:34:30 UTC
Created attachment 168430 [details]
[patch] Existing keysyms are translated - others are copied

Dear Baptiste,

please find attached a patch which works for me.
The modifications are:

1) Change the error to a print to continue operation.
2) In case of a missing key code just insert the code
into the config file instead of the description.

This is the first patch file in x11-wm/i3. May be therefore
svnlite-diff gives no output. I have no idea. Therefore I
attached the patch only.

Poudriere on 
====>> Building x11-wm/i3
build started at Sun Mar 20 17:49:19 CET 2016
port directory: /usr/ports/x11-wm/i3
building for: FreeBSD pkg.esprimo.local 10.3-PRERELEASE FreeBSD 10.3-PRERELEASE amd64
maintained by: bapt@FreeBSD.org
Makefile ident:      $FreeBSD: head/x11-wm/i3/Makefile 410667 2016-03-08 21:43:28Z bapt $
Poudriere version: 3.1.12
Host OSVERSION: 1003500
Jail OSVERSION: 1002508

is happy.
portlint -C outputs a warning
WARN: Makefile: [49]: do not use muted INSTALL_foo commands (i.e., those that start with '@').  These should be printed.
0 fatal errors and 1 warning found.
Comment 6 c.brinkhaus 2016-03-20 17:39:59 UTC
Created attachment 168431 [details]
Working config generated with patch applied

Dear Baptiste,

please find attached a new generated config file for your reference.

Kind regards,
Christoph
Comment 7 c.brinkhaus 2016-03-20 18:57:42 UTC
Created attachment 168433 [details]
[patch] Existing keysyms are translated - others are copied - svndiff

Dear Baptiste,

please find attached the svndiff.
Unfortunately it took me some time to find the description how to track changes. Finally I found it well documented in the Porters Handbook. What a surprise;-).
I did not mark the patch file itself as obsolete because there are some lines at the bottom of the svn diff file which make me unsure.

Kind regards,
Christoph
Comment 8 Walter Schwarzenfeld freebsd_triage 2018-01-14 05:14:46 UTC
ping!