Bug 208101 - "Bail out" is the wrong approach to not being able to load a geom class in tests/sys/geom
Summary: "Bail out" is the wrong approach to not being able to load a geom class in te...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Enji Cooper
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-17 21:43 UTC by Enji Cooper
Modified: 2017-01-02 03:36 UTC (History)
0 users

See Also:
ngie: mfc-stable10?
ngie: mfc-stable9-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer freebsd_triage 2016-03-17 21:43:59 UTC
Bail out counts as a failure, not a SKIP test plan. This was the wrong approach for me to implement in tests/sys/geom as individuals who don't have geom modules available on their system will get several false positives when not able to load the classes >_>...
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-03-22 08:13:15 UTC
A commit references this bug:

Author: ngie
Date: Tue Mar 22 08:12:45 UTC 2016
New revision: 297183
URL: https://svnweb.freebsd.org/changeset/base/297183

Log:
  Use a SKIP testplan instead of bailing out if/when the tester isn't
  root, or the geom class can't be loaded cleanly [*]

  This makes sure that scenarios that are easy to hit aren't counted
  as false positives with kyua test

  MFC after: 1 week
  PR: 208101
  Sponsored by: EMC / Isilon Storage Division

Changes:
  head/tests/sys/geom/class/geom_subr.sh
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-04-06 06:38:12 UTC
A commit references this bug:

Author: ngie
Date: Wed Apr  6 06:37:37 UTC 2016
New revision: 297612
URL: https://svnweb.freebsd.org/changeset/base/297612

Log:
  MFC r297183:

  Use a SKIP testplan instead of bailing out if/when the tester isn't
  root, or the geom class can't be loaded cleanly [*]

  This makes sure that scenarios that are easy to hit aren't counted
  as false positives with kyua test

  PR: 208101

Changes:
_U  stable/10/
  stable/10/tests/sys/geom/class/geom_subr.sh