Created attachment 168493 [details]
patch adding -fPIC
Added needed CFLAGS+= -fPIC, bumped PORTREVISION
What problem does it solve? And is it required on every ARCH?
dyncall is often used in scripting language extensions, which are shared libraries. Without fPIC, building those would fail.
dyncall's configure step actually adds -fPIC for all FreeBSD builds, *if* CFLAGS isn't already set by the user. Since the ports tree sets it, the result is that fPIC isn't used.
This simply adds it back for FreeBSD builds.
I *think* this would be required for all the platforms, as dyncall itself would set it for all FreeBSD builds, I wouldn't see why dynamic linking logic would work on arm differently than x86? Maybe I'm missing something?
A commit references this bug:
Date: Wed Mar 30 17:30:47 UTC 2016
New revision: 412177
Add -fPIC to CFLAGS; bump PORTREVISION
PIC is required for this port to work properly. However, the
port's own build system only adds it if CFLAGS is not set in MAKE_ENV.
This adds -fPIC to the pre-defined set of CFLAGS to ensure the port
is properly built.
Submitted by: firstname.lastname@example.org (maintainer)
(In reply to Tassilo Philipp from comment #2)
No worries, you are not missing anything. I just wanted to make sure that I fully understand the intention of this patch. Committed, thank you!