Bug 208216 - net-mgmt/cdpd: runtime broken on armv6
Summary: net-mgmt/cdpd: runtime broken on armv6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL: https://lists.freebsd.org/pipermail/f...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-22 18:44 UTC by Mikael Urankar
Modified: 2016-08-23 01:52 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sem)

Attachments
fix for armv6 (773 bytes, patch)
2016-03-22 18:44 UTC, Mikael Urankar 		no flags Details | Diff
bump portrevision (1.03 KB, patch)
2016-03-23 09:12 UTC, Mikael Urankar 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2016-03-22 18:44:49 UTC 
Created attachment 168508 [details]
fix for armv6

Hi,

cdpd does not work on armv6, see https://lists.freebsd.org/pipermail/freebsd-arm/2016-March/013464.html for details.
The attached patch fixes the issue (getopt returns an 'int' not a 'char', char is unsigned on arm eabi)
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2016-03-23 09:12:44 UTC 
Created attachment 168526 [details]
bump portrevision
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2016-03-23 15:31:50 UTC 
Response from Scott (freebsd-lists-5 at thismonkey.com)

Hi!

Thanks for the quick reply.  That patch worked perfectly, thanks.

Just for my education: did the truss output assist at all?  If so, what was
the relevant line(s) that led to the patch?
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2016-08-21 11:21:05 UTC 
maintainer reset
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-08-23 01:52:07 UTC 
A commit references this bug:

Author: marino
Date: Tue Aug 23 01:51:21 UTC 2016
New revision: 420640
URL: https://svnweb.freebsd.org/changeset/ports/420640

Log:
  net-mgmt/cdpd: Fix runtime on armv6

  While here, pet portlint and define the 2-clause BSD license

  PR:		208216
  Submitted by:	Mikael Urankar (gmail)

Changes:
  head/net-mgmt/cdpd/Makefile
  head/net-mgmt/cdpd/files/patch-cdpd.c