Bug 208227 - devel/arcanist: add optional dependency on mbstring for encodings support
Summary: devel/arcanist: add optional dependency on mbstring for encodings support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Michael Gmelin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-23 02:09 UTC by Dmitry Marakasov
Modified: 2016-03-26 20:54 UTC (History)
0 users

See Also:
grembo: maintainer-feedback+


Attachments
Patch (597 bytes, patch)
2016-03-23 02:09 UTC, Dmitry Marakasov
grembo: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer 2016-03-23 02:09:25 UTC
Created attachment 168523 [details]
Patch

Arcanist does support encodings other than utf-8, but it needs mbstring php extension for this, otherwise an attempt to use --encoding argument will lead to an error:

% arc diff --encoding koi8-r --update D5713 ru_RU.KOI8-R/books/handbook/x11/chapter.xml
Linting...
No lint engine configured for this project.
Running unit tests...
No unit test engine is configured for this project.
Exception
Attempting to convert a string encoding from 'koi8-r' to 'UTF-8', but the 'mbstring' PHP extension is not available. Install mbstring to work with encodings other than UTF-8.
(Run with `--trace` for a full exception trace.)

To support this, add an optional dependency on mbstring for arcanist. Enable it by default, since it's crucial for working with localized FreeBSD documentation, which still uses obsolete 8 bit locales.
Comment 1 commit-hook freebsd_committer 2016-03-26 20:40:51 UTC
A commit references this bug:

Author: grembo
Date: Sat Mar 26 20:40:11 UTC 2016
New revision: 411965
URL: https://svnweb.freebsd.org/changeset/ports/411965

Log:
  Add optional dependency on mbstring for encodings support

  This is enabled by default to allow FreeBSD developers to
  work with localized FreeBSD documenentation.

  PR:		208227
  Submitted by:	amdmi3
  Approved by:	mentors (implicit)

Changes:
  head/devel/arcanist/Makefile
Comment 2 Michael Gmelin freebsd_committer 2016-03-26 20:54:48 UTC
Thanks!