Bug 208249 - math/geogebra: [PATCH] update to 5.0.218.0, add plus MASTER_SITES
Summary: math/geogebra: [PATCH] update to 5.0.218.0, add plus MASTER_SITES
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-03-23 16:39 UTC by Zsolt Udvari
Modified: 2016-03-25 12:34 UTC (History)
0 users

See Also:
uzsolt: maintainer-feedback+


Attachments
patch (1.18 KB, text/plain)
2016-03-23 16:39 UTC, Zsolt Udvari
no flags Details
Extended patch (3.37 KB, patch)
2016-03-24 19:04 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolt Udvari freebsd_committer freebsd_triage 2016-03-23 16:39:56 UTC
Created attachment 168543 [details]
patch

* update to 5.0.218.0
* add MASTER_SITES (my homepage) because on geogebra-server can't find older versions only the latest

poudriere log: http://freebsd.uzsolt.hu/logs/geogebra/geogebra-5.0.218.0.log
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2016-03-24 19:04:26 UTC
Created attachment 168576 [details]
Extended patch

The port has numerous problems so I propose extended patch:

- Use LICENSE_FILE instead of LICENSE_TEXT, as the license is available in the package
- Fix LICENSE_PERMS. Given the license is non-commercial, current perms are incorrect since they allow selling and not mirroring distfiles and packages, while it should be vice versa
- Whitespace fixes
- Fix bash shebang for another script
- Don't modify package contents in do-install, there's patch target for this stuff
- Don't use single command in do-install, it's cumbersome, error-prone and hard to debug
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2016-03-24 19:08:19 UTC
Also, why does it bundle JRE? Can't it be run with our native JRE without need for linux and untrusted bundled binaries?
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2016-03-24 19:23:53 UTC
I tried it without bundled-JRE but I couldn't. As I see geogebra uses a precompiled linux-binary.
When I try system-JRE:
$ java  -Xms32m -Xmx1024m -Dawt.useSystemAAFontSettings=on -cp /usr/local/share/geogebra/geogebra/geogebra.jar -Xbootclasspath/a:/usr/local/share/geogebra/jre1.7.0_45-i686/bin/../lib/jfxrt.jar org.geogebra.desktop.GeoGebra3D --showSplash=false --settingsfile=/usr/local/share/geogebra/.config/geogebra-portable/geogebra.properties --settingsfile=/usr/local/share/geogebra/geogebra.properties

Error message:
Catched FileNotFoundException: /usr/local/share/geogebra/geogebra/gluegen-rt-natives-freebsd-amd64.jar (No such file or directory), while addNativeJarLibsImpl(classFromJavaJar class com.jogamp.common.os.Platform, classJarURI jar:file:/usr/local/share/geogebra/geogebra/gluegen-rt.jar!/com/jogamp/common/os/Platform.class, nativeJarBaseName gluegen-rt-natives-freebsd-amd64.jar): [ file:/usr/local/share/geogebra/geogebra/gluegen-rt.jar -> file:/usr/local/share/geogebra/geogebra/ ] + gluegen-rt-natives-freebsd-amd64.jar -> slim: jar:file:/usr/local/share/geogebra/geogebra/gluegen-rt-natives-freebsd-amd64.jar!/
Exception in thread "main" java.lang.UnsatisfiedLinkError: Can't load library: /usr/local/share/geogebra/libgluegen-rt.so


I can't resolve it. Do you have any idea?
Comment 4 Zsolt Udvari freebsd_committer freebsd_triage 2016-03-24 19:27:07 UTC
Sorry, I forgot but it belongs to prev comment: when I replace 'java' to '/usr/local/share/geogebra/jre1.7.0_45-i686/bin/java' it works well.
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2016-03-24 20:19:21 UTC
(In reply to Zsolt Udvari from comment #3)

> I can't resolve it. Do you have any idea?

Not really, I not really into java. All right then, if you're OK with the updated patch I'll commit it.
Comment 6 Zsolt Udvari freebsd_committer freebsd_triage 2016-03-25 08:04:54 UTC
Yes, the updated patch is very good, please commit!
Many thanks for your work!
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-03-25 12:34:55 UTC
A commit references this bug:

Author: amdmi3
Date: Fri Mar 25 12:34:47 UTC 2016
New revision: 411835
URL: https://svnweb.freebsd.org/changeset/ports/411835

Log:
  - Update to 5.0.218.0 and add mirror, fixing fetch
  - Fix LICENSE
  - Simplify installation

  PR:		208249
  Submitted by:	udvzsolt@gmail.com (maintainer)

Changes:
  head/math/geogebra/Makefile
  head/math/geogebra/distinfo