Bug 208531 - databases/opentsdb: check_tsd has invalid python path
Summary: databases/opentsdb: check_tsd has invalid python path
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Lars Engels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-04 20:30 UTC by Johan Ström
Modified: 2016-04-23 12:01 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (xmj)

Attachments
fix shebang & java-version being 1.7 (2.12 KB, patch)
2016-04-08 16:36 UTC, Johannes Jost Meixner 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Ström 2016-04-04 20:30:01 UTC 
/usr/local/share/opentsdb/tools/check_tsd uses '#!/usr/bin/python', which never (?) exists on FreeBSD.

Workaround is to just run 'python /usr/local/share/opentsdb/tools/check_tsd'

Although, it still does not work, due to https://github.com/OpenTSDB/opentsdb/issues/760.

Commented out that whole section, and it works.
Comment 1 Johannes Jost Meixner freebsd_committer freebsd_triage 2016-04-04 22:51:22 UTC 
Proper workaround will be to use #!/usr/bin/env python, I'll work something out and add a fix for running it with the correct JAVA_VERSION as well.
Comment 2 Johannes Jost Meixner freebsd_committer freebsd_triage 2016-04-05 09:23:55 UTC 
https://github.com/OpenTSDB/opentsdb/pull/761
Comment 3 Johannes Jost Meixner freebsd_committer freebsd_triage 2016-04-08 16:36:36 UTC 
Created attachment 169109 [details]
fix shebang & java-version being 1.7

Patch attached adds shebangfix to take care of #!/usr/bin/python issues, and adds setting the correct Java version (1.8 or later), so that javavmwrapper can do its thing.
Comment 4 Lars Engels freebsd_committer freebsd_triage 2016-04-23 12:01:45 UTC 
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-04-23 12:01:53 UTC 
A commit references this bug:

Author: lme
Date: Sat Apr 23 12:01:12 UTC 2016
New revision: 413866
URL: https://svnweb.freebsd.org/changeset/ports/413866

Log:
  - Use shebangfix for check_tsd
  - Use Java 1.8+
  - Bump PORTREVISION

  PR:		        208531
  Submitted by:	Johan Str?m <johan@stromnet.se>
  Approved by:	maintainer
  Sponsored by:	Essen Linuxhotel Hackathon 2016

Changes:
  head/databases/opentsdb/Makefile