Created attachment 169002 [details] patch Testbuilds fine, portlint -AC is fine, only dependency security/py-pymacaroons-pynacl is not version-sensible.
Hey, Thanks for the patch! I've dropped the ball a bit lately (recovering from a sinus operation since two weeks ago). Could you do me a massive favour and check that the tests for `security/py-pymacaroons-pynacl` still run and pass? I ask because this is a major version bump, which implies API breakage.
Changelog: https://github.com/DRMacIver/hypothesis/blob/master/docs/changes.rst make test for security/py-pymacaroons-pynacl fails: ====================================================================== ERROR: Failure: ImportError (cannot import name strategy) ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/local/lib/python2.7/site-packages/nose/loader.py", line 418, in loadTestsFromName addr.filename, addr.module) File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 47, in importFromPath return self.importFromDir(dir_path, fqname) File "/usr/local/lib/python2.7/site-packages/nose/importer.py", line 94, in importFromDir mod = load_module(part_fqname, fh, filename, desc) File "/usr/ports/security/py-pymacaroons-pynacl/work/pymacaroons-0.9.3/tests/property_tests/macaroon_property_tests.py", line 5, in <module> from hypothesis import assume, given, strategy ImportError: cannot import name strategy ---------------------------------------------------------------------- Ran 22 tests in 0.154s FAILED (SKIP=1, errors=1) If I test with 1.18.1, it is sucessful.
Well this sucks, though there will be other packages in the future that rely on hypothesis 1.x anyway. We may have to repackage hypothesis 3.1.0 as devel/py-hypothesis3 so packages that still rely on the 1.x series (there is no 2.x as they pulled it very quickly and incremented to 3.x) can still function appropriately.
Submitter is committer.
Created attachment 187321 [details] Update to 3.33.0 I am not sure what happened with the previous patch. security/py-pymacaroons-pynacl isn't a dependency in 3.33.0 Passes poudriere 11.1 amd64.
(In reply to Yuri Victorovich from comment #5) security/py-pymacaroons-pynacl has py-hypothesis as TEST_DEPENDS. With 1.18.1 installed, security/py-pymacaroons-pynacl passes all 22 tests. With 3.33.0 installed, security/py-pymacaroons-pynacl fails one of them: ERROR: Failure: ImportError (cannot import name strategy)
Btw, testbuilds are fine: cur 111 10i
(In reply to Kurt Jaeger from comment #6) I think the cause is some bug in devel/py-nose, but my py-foo is weak...
(In reply to Kurt Jaeger from comment #8) > ERROR: Failure: ImportError (cannot import name strategy) 'strategy' isn't exported from py-hypothesis any more. It has 'searchstrategy' now. security/py-pymacaroons-pynacl gets source from https://github.com/matrix-org/pymacaroons This github project seems to be not up-to-date. https://pypi.python.org/pypi/pymacaroons says that the latest version is 0.12.0, not 0.9.3. I suggest: * to switch to the latest python version as it appears on https://pypi.python.org/pypi/pymacaroons * to remove '-pynacl' from the port name. Yuri
Tested make test with security/py-pymacaroons @0.12, same error: ERROR: Failure: ImportError (No module named specifiers) So besides an update, pymacaroons needs some patch as well to work with hypothesis-3.33.0 ?
(In reply to Kurt Jaeger from comment #10) Then this is a bug in upstream of py-pymacaroons. They might be the best party that can help.
MARKED AS SPAM
py-hypothesis has version 3.56.5. See https://svnweb.freebsd.org/ports?view=revision&revision=468449 I close here, overcome by events.