Bug 208817 - multimedia/libxine: Fix build with ffmpeg 3.0.x
Summary: multimedia/libxine: Fix build with ffmpeg 3.0.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks: 207547
  Show dependency treegraph
 
Reported: 2016-04-15 15:16 UTC by Ben Woods
Modified: 2016-04-15 16:49 UTC (History)
0 users

See Also:


Attachments
Patch to fix build of multimedia/libxine using ffmpeg 3.0.x (2.95 KB, patch)
2016-04-15 15:16 UTC, Ben Woods
woodsb02: maintainer-approval+
Details | Diff
QA: Successful poudriere testport logs for multimedia/libxine with patch against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 11-current amd64 (696.35 KB, text/plain)
2016-04-15 15:18 UTC, Ben Woods
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Woods freebsd_committer 2016-04-15 15:16:46 UTC
Created attachment 169339 [details]
Patch to fix build of multimedia/libxine using ffmpeg 3.0.x

multimedia/libxine: Fix build with ffmpeg 3.0.x

Add patch to allow libxine to build successfully once multimedia/ffmpeg is updated to 3.0.x. Note that multimedia/ffmpeg is currently still on the 2.8.x branch, however this patch is backwards compatible with ffmpeg 2.8.x.
Comment 1 Ben Woods freebsd_committer 2016-04-15 15:18:54 UTC
Created attachment 169340 [details]
QA: Successful poudriere testport logs for multimedia/libxine with patch against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 11-current amd64
Comment 2 Ben Woods freebsd_committer 2016-04-15 15:48:08 UTC
These patches were obtained from the Archlinux repository:
https://projects.archlinux.org/svntogit/packages.git/tree/trunk/xine-lib-ffmpeg3.patch?h=packages/xine-lib
Comment 3 commit-hook freebsd_committer 2016-04-15 16:46:42 UTC
A commit references this bug:

Author: jbeich
Date: Fri Apr 15 16:46:25 UTC 2016
New revision: 413354
URL: https://svnweb.freebsd.org/changeset/ports/413354

Log:
  multimedia/libxine: unbreak build with ffmpeg 3.0

  ff_audio_decoder.c:593:22: error: implicit declaration of function 'avcodec_alloc_frame' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
      this->av_frame = avcodec_alloc_frame ();
                       ^
  ff_audio_decoder.c:1074:5: error: implicit declaration of function 'avcodec_free_frame' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
      avcodec_free_frame (&this->av_frame);
      ^

  PR:		208817
  Reported by:	antoine (via exp-run)
  Submitted by:	Ben Woods <woodsb02@gmail.com>
  Obtained from:	Arch Linux
  MFH:		2016Q2 (just-in-case "fix it" blanket)

Changes:
  head/multimedia/libxine/Makefile
  head/multimedia/libxine/files/patch-ffmpeg3
Comment 4 Jan Beich freebsd_committer 2016-04-15 16:49:01 UTC
Thanks. Committed.