Bug 208821 - multimedia/ffmpegthumbnailer: Update to 2.1.1
Summary: multimedia/ffmpegthumbnailer: Update to 2.1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Raphael Kubo da Costa
URL: https://github.com/dirkvdb/ffmpegthum...
Keywords:
Depends on:
Blocks: 207547
  Show dependency treegraph
 
Reported: 2016-04-15 16:12 UTC by Ben Woods
Modified: 2016-04-16 17:10 UTC (History)
2 users (show)

See Also:
woodsb02: maintainer-feedback+


Attachments
Patch to update multimedia/ffmpegthumbnailer to 2.1.1 (7.69 KB, patch)
2016-04-15 16:12 UTC, Ben Woods
woodsb02: maintainer-approval+
Details | Diff
QA: Successful poudriere testport logs for multimedia/ffmpegthumbnailer 1.3.1 against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 11-current amd64 (1.43 KB, text/plain)
2016-04-15 16:16 UTC, Ben Woods
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Woods freebsd_committer 2016-04-15 16:12:21 UTC
Created attachment 169346 [details]
Patch to update multimedia/ffmpegthumbnailer to 2.1.1

- Update multimedia/ffmpegthumbnailer to 2.1.1
- Convert to USE_GITHUB
- Convert to USES=cmake
- Add patch to prevent cmake trying to find the dl library, since in FreeBSD the dl functions are in the Standard C library (libc) - see dlopen(3)
- Pet portlint with other patches (remake the patches with makepatch)


This update also allows multimedia/ffmpegthumbnailer to build against ffmpeg 3.0.x. The ports tree currently still has multimedia/ffmepg at version 2.8.6, however this update is backwards compatible with ffmpeg 2.8.6. The update of multimedia/ffmpeg to 3.0.x branch is waiting for ports which depend on it to successfully build with the newer version of ffmpeg.
Comment 1 Ben Woods freebsd_committer 2016-04-15 16:15:13 UTC
Changes this release:
  https://github.com/dirkvdb/ffmpegthumbnailer/blob/2.1.1/ChangeLog
Comment 2 Ben Woods freebsd_committer 2016-04-15 16:16:20 UTC
Created attachment 169347 [details]
QA: Successful poudriere testport logs for multimedia/ffmpegthumbnailer 1.3.1 against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 11-current amd64
Comment 3 clutton 2016-04-15 18:22:46 UTC
(In reply to Ben Woods from comment #2)

I've tested it, it works. You have my appreciations for doing upgrading.
Comment 4 Raphael Kubo da Costa freebsd_committer 2016-04-16 17:07:40 UTC
Hi Ben,

I'll land a slightly modified version of your patch with some cosmetic changes:
* GNU_CONFIGURE=yes is no longer needed now that the port uses CMake.
* It's not necessary to set GH_PROJECT when it's the same as PORTNAME.
* I'm joining both CMAKE_ARGS assignments for consistency with what we normally do, and it's OK to use 'CMAKE_ARGS=' instead of 'CMAKE_ARGS+=' by default.
* I've modified the CMakeLists.txt patch: instead of commenting out some lines, the code now uses the standard CMAKE_LIBS variable. I've also upstreamed this in <https://github.com/dirkvdb/ffmpegthumbnailer/pull/132>.
Comment 5 commit-hook freebsd_committer 2016-04-16 17:09:41 UTC
A commit references this bug:

Author: rakuco
Date: Sat Apr 16 17:09:08 UTC 2016
New revision: 413461
URL: https://svnweb.freebsd.org/changeset/ports/413461

Log:
  Update to 2.1.1.

  - Convert to USE_GITHUB.
  - Convert to USES=cmake.
  - Add patch to prevent cmake trying to find the dl library, since in FreeBSD
    the dl functions are in the Standard C library (libc) - see dlopen(3)
  - Pet portlint with other patches (remake the patches with makepatch)

  This update also allows multimedia/ffmpegthumbnailer to build against ffmpeg
  3.0.x. The ports tree currently still has multimedia/ffmepg at version 2.8.6,
  however this update is backwards compatible with ffmpeg 2.8.6. The update of
  multimedia/ffmpeg to 3.0.x branch is waiting for ports which depend on it to
  successfully build with the newer version of ffmpeg.

  PR:		208821
  Submitted by:	Ben Woods <woodsb02@gmail.com>
  Approved by:	clutton@zoho.com (maintainer)

Changes:
  head/multimedia/ffmpegthumbnailer/Makefile
  head/multimedia/ffmpegthumbnailer/distinfo
  head/multimedia/ffmpegthumbnailer/files/patch-CMakeLists.txt
  head/multimedia/ffmpegthumbnailer/files/patch-dist_ffmpegthumbnailer.thumbnailer
  head/multimedia/ffmpegthumbnailer/files/patch-libffmpegthumbnailer_jpegwriter.h
  head/multimedia/ffmpegthumbnailer/pkg-descr
  head/multimedia/ffmpegthumbnailer/pkg-plist
Comment 6 Raphael Kubo da Costa freebsd_committer 2016-04-16 17:10:04 UTC
Committed, thanks everyone.