Bug 208822 - multimedia/vlc: Add FFMPEG_SUFFIX variable
Summary: multimedia/vlc: Add FFMPEG_SUFFIX variable
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-15 16:31 UTC by Ben Woods
Modified: 2016-11-13 22:36 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (multimedia)

Attachments
Patch to add Add FFMPEG_SUFFIX variable to multimedia/vlc port (2.08 KB, patch)
2016-04-15 16:31 UTC, Ben Woods 		woodsb02: maintainer-approval? (multimedia)
 Details | Diff
QA: Successful poudriere testport logs for multimedia/vlc with patch against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 11-current amd64 (gzipped) (185.05 KB, application/gzip)
2016-04-15 16:45 UTC, Ben Woods 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Woods freebsd_committer freebsd_triage 2016-04-15 16:31:09 UTC 
Created attachment 169348 [details]
Patch to add Add FFMPEG_SUFFIX variable to multimedia/vlc port

multimedia/vlc:

Add FFMPEG_SUFFIX variable which when set to XX will cause the multimedia/vlc port to depend upon multimedia/ffmpegXX. The latest release of vlc at the time of the bug report (2.2.2) does not successfully build with ffmpeg3. The FFMPEG_SUFFIX variable is left blank for now (no impact to the current port), but may be used once multimedia/ffmpeg is updated to the 3.0.x branch if a newer version of vlc has not yet been released which successfully builds against ffmpeg3 (a new port multimedia/ffmpeg28 could be created and used to satisfy vlc dependencies).
Comment 1 Ben Woods freebsd_committer freebsd_triage 2016-04-15 16:45:19 UTC 
Created attachment 169351 [details]
QA: Successful poudriere testport logs for multimedia/vlc with patch against current ports tree (FFmpeg 2.8.6_2,1) on FreeBSD 11-current amd64 (gzipped)
Comment 2 Jan Beich freebsd_committer freebsd_triage 2016-04-15 17:18:56 UTC 
Comment on attachment 169348 [details]
Patch to add Add FFMPEG_SUFFIX variable to multimedia/vlc port

Maybe create USES=ffmpeg instead. This looks generic enough that multimedia/ffmpeg0 and multimedia/libav may want to take advantage of.
Comment 3 Ben Woods freebsd_committer freebsd_triage 2016-11-13 22:36:00 UTC 
Patches were added to multimedia/vlc in r426055 to allow it to build with ffmpeg 3.x.