Created attachment 170724 [details] Update from version 0.3 to 0.3_1 to remove unnecessary build time tests. Build time tests in the radamsa package are stochastic and they experience sporadic failures. Simply remove them. They are not necessary for radamsa to operate properly.
Thanks for your submission. As the maintainer of the port, please set the maintainer-approval+ flag on your patch.
Question, though. If this fixes a build-time problem, even more so tests, does it need a PORTREVISION bump? Does this fix change the package itself?
Yes. PORTREVISION is set to 1 in the Makefile.
I've seen it, that's what I was asking, if it was necessary to trigger a reinstallation. :)
Well, in reality it is not absolutely necessary, of course. I just considered it as proper form when a package changes such that something is no longer done. Personally I prefer to rebuild packages from scratch for almost no reason at all. Someone building packages on a less powerful system might not share my enthusiasm. I fully understand if you prefer leaving the whole PORTREVISION line out of the Makefile.
A commit references this bug: Author: riggs Date: Tue Aug 2 18:29:25 UTC 2016 New revision: 419490 URL: https://svnweb.freebsd.org/changeset/ports/419490 Log: Remove stochasting build-time tests Detailed maintainer explanation: Build time tests in the radamsa package are stochastic and they experience sporadic failures. Simply remove them. They are not necessary for radamsa to operate properly. PR: 209792 Submitted by: jau@iki.fi Reviewed by: riggs Changes: head/security/radamsa/files/patch-Makefile
Committed only patch-Makefile. Rationale: - pkg does not change, so PORTREVISION bump is unnecessary - NEED_ROOT is unnecessary. make package as non root user works fine. - COMMENT should not start with "a" anyway, see portlint -ca output :-)