Bug 210153 - [patch] net/openntpd: Allow setting config location, and add a configtest command
Summary: [patch] net/openntpd: Allow setting config location, and add a configtest com...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Christian Weisgerber
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-06-08 23:51 UTC by Adam Weinberger
Modified: 2016-06-09 15:49 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (naddy)


Attachments
openntpd rc(8) patch (1.41 KB, patch)
2016-06-08 23:51 UTC, Adam Weinberger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer 2016-06-08 23:51:54 UTC
Created attachment 171220 [details]
openntpd rc(8) patch

Hi Christian,

Attached patch adds support for
  openntpd_config="/path/to/ntpd.conf"
and for
  service openntpd configtest

configtest gets run before every startup.

It also documents openntpd_flags at the top of rc.d/openntpd.

Patch includes a PORTREVISION bump.
Comment 1 Christian Weisgerber freebsd_committer 2016-06-09 15:37:32 UTC
Should checkconfig() include a line like

  echo "Performing sanity check on ${name} configuration:"

?
Either way, I'm fine with this, please commit.
Comment 2 commit-hook freebsd_committer 2016-06-09 15:48:24 UTC
A commit references this bug:

Author: adamw
Date: Thu Jun  9 15:47:59 UTC 2016
New revision: 416613
URL: https://svnweb.freebsd.org/changeset/ports/416613

Log:
  Add support for changing the location of ntpd.conf (openntpd_config),
  and add a 'configtest' rc(8) target. Also note openntpd_flags in the
  comments at the top of the rc(8) script.

  PORTREVISION bump for rc(8) script change.

  PR:		210153
  Approved by:	naddy (maintainer)

Changes:
  head/net/openntpd/Makefile
  head/net/openntpd/files/openntpd.in
Comment 3 Adam Weinberger freebsd_committer 2016-06-09 15:49:06 UTC
Good call on that extra line. I've committed this patch. Thanks, Christian!