Bug 210220 - www/firefox in preferences general tab and "data choices" in advanced tab are empty
Summary: www/firefox in preferences general tab and "data choices" in advanced tab are...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: freebsd-gecko (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-11 20:23 UTC by Marco Beishuizen
Modified: 2016-09-12 00:01 UTC (History)
1 user (show)

See Also:
jbeich: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Beishuizen 2016-06-11 20:23:23 UTC
In FF 47 (since FF 46) the general tab and the data choices in the advanced tab don't show anything. Data choices is just empty, clicking the general tab does nothing. I'm running FreeBSD 10.3-STABLE #1 r297561.
Comment 1 Marco Beishuizen 2016-06-11 22:15:14 UTC
I should also add that Adblock Plus is the only extension installed and the build options that are on are: DBUS, FFMPEG, OPTIMIZED_CFLAGS, ALSA and GTK2. The rest of the options are set to off.

FF 45.2 ESR does not have this problem.
Comment 2 Marco Beishuizen 2016-06-12 10:10:33 UTC
FF also keeps asking to be the default browser every time it starts. Confirming and unchecking the "ask every time" option does not change this. This is probably related since this is a setting in the general tab.
Comment 3 Arrigo Marchiori 2016-06-21 09:19:32 UTC
Hello,

this also happens on my system (9.3-STABLE i386).

I tried to create a new profile, and the problem remains. This suggests that the problem is not due to user profile data.

$ uname -a
FreeBSD sviluppo5 9.3-STABLE FreeBSD 9.3-STABLE #161 r301877M: Tue Jun 14 09:41:30 CEST 2016     root@myhost:/usr/obj/usr/src/sys/GENERIC  i386

$ svn info /usr/ports/www/firefox | grep Revision
Revision: 417139

$ cat /var/db/ports/www_firefox/options 
_OPTIONS_READ=firefox-46.0.1,1
_FILE_COMPLETE_OPTIONS_LIST=BUNDLED_CAIRO CANBERRA DBUS DEBUG FFMPEG GCONF GIO GNOMEUI INTEGER_SAMPLES LIBPROXY OPTIMIZED_CFLAGS PGO PROFILE RUST TEST GTK2 GTK3 ALSA PULSEAUDIO
OPTIONS_FILE_UNSET+=BUNDLED_CAIRO
OPTIONS_FILE_SET+=CANBERRA
OPTIONS_FILE_SET+=DBUS
OPTIONS_FILE_UNSET+=DEBUG
OPTIONS_FILE_SET+=FFMPEG
OPTIONS_FILE_UNSET+=GCONF
OPTIONS_FILE_UNSET+=GIO
OPTIONS_FILE_UNSET+=GNOMEUI
OPTIONS_FILE_UNSET+=INTEGER_SAMPLES
OPTIONS_FILE_UNSET+=LIBPROXY
OPTIONS_FILE_UNSET+=OPTIMIZED_CFLAGS
OPTIONS_FILE_UNSET+=PGO
OPTIONS_FILE_UNSET+=PROFILE
OPTIONS_FILE_UNSET+=RUST
OPTIONS_FILE_UNSET+=TEST
OPTIONS_FILE_SET+=GTK2
OPTIONS_FILE_UNSET+=GTK3
OPTIONS_FILE_SET+=ALSA
OPTIONS_FILE_SET+=PULSEAUDIO
Comment 4 Arrigo Marchiori 2016-07-05 07:41:57 UTC
FWIW, the problem seems to be present also on firefox-47.0.1,1

$ svn info /usr/ports/www/firefox | grep Revision
Revision: 418008
Comment 5 Jan Beich freebsd_committer freebsd_triage 2016-07-09 14:08:56 UTC
As noted in comment 0 this is an upstream regression in 47.0. There were no recent changes to the file, so I may need to bisect.

https://dxr.mozilla.org/mozilla-central/source/browser/components/preferences/in-content/advanced.xul#207
Comment 6 Arrigo Marchiori 2016-07-11 07:00:56 UTC
Hello Jan, thank you for your assistance.

I could dig a bit into this.

There seems to be an exception raised in preferences.js:131 (inside function gotoPref(acategory)) by function init_category_if_required()

Exception type: TypeError
fileName: resource:///modules/ShellService.jsm
lineNumber: 105
message: "target.shellService is undefined"
stack: "get@resource:///modules/ShellService.jsm:105:1isDefaultBrowser@resource:///modules/ShellService.jsm:90:1gMainPane.updateSetDefaultBrowser@chrome://browser/content/preferences/in-content/main.js:542:21gMainPane.init@chrome://browser/content/preferences/in-content/main.js:29:5register_module/<.init@chrome://browser/content/preferences/in-content/preferences.js:34:7init_category_if_required@chrome://browser/content/preferences/in-content/preferences.js:27:3gotoPref@chrome://browser/content/preferences/in-content/preferences.js:131:5init_all/<@chrome://browser/content/preferences/in-content/preferences.js:59:50_fireOnSelect@chrome://global/content/bindings/richlistbox.xml:77:13selectItem@chrome://global/content/bindings/listbox.xml:243:11onxblmousedown@chrome://global/content/bindings/listbox.xml:974:13"

I don't know where to go from here... But I hope this helps, if you didn't have this information already.
Comment 7 Jan Beich freebsd_committer freebsd_triage 2016-07-11 12:33:21 UTC
My bisecting led me to the following commit as the first bad. Someone already filed an upstream bug (See Also).

https://hg.mozilla.org/mozilla-central/rev/1ce8c9bac2a7
Comment 8 Arrigo Marchiori 2016-07-11 13:24:26 UTC
Jan, thank you for the pointer.

In fact I believe that the upstream bug only refers to the "Data choices" tab in the "Advanced" page.
It does not seem to talk about the "General" tab. My comment #3 was about the "General" tab.
Maybe we should split this bug?
Comment 9 Jan Beich freebsd_committer freebsd_triage 2016-07-13 03:34:14 UTC
Can you try to enable GIO option?
Comment 10 Arrigo Marchiori 2016-07-13 08:08:59 UTC
(In reply to Jan Beich from comment #9)
> Can you try to enable GIO option?

Bingo! That fixes the "General" pane!

Are there any other tests I could do, in order to help fixing this?
Comment 11 commit-hook freebsd_committer freebsd_triage 2016-09-08 06:50:16 UTC
A commit references this bug:

Author: jbeich
Date: Thu Sep  8 06:49:24 UTC 2016
New revision: 421533
URL: https://svnweb.freebsd.org/changeset/ports/421533

Log:
  gecko: drop poorly maintained GIO=off case after r376999

  Glib IO is already used by Gtk internally, so there's little reason
  to avoid it unless using non-Gtk builds which are no longer supported.

  https://bugzilla.mozilla.org/show_bug.cgi?id=1286627
  https://bugzilla.mozilla.org/show_bug.cgi?id=1287288

  PR:		210220
  Reported by:	Marco Beishuizen, Arrigo Marchiori
  MFH:		2016Q3

Changes:
  head/Mk/bsd.gecko.mk
  head/www/firefox/Makefile.options
Comment 12 Arrigo Marchiori 2016-09-08 08:17:23 UTC
Thank you, Jan!
Comment 13 commit-hook freebsd_committer freebsd_triage 2016-09-12 00:01:51 UTC
A commit references this bug:

Author: jbeich
Date: Mon Sep 12 00:00:52 UTC 2016
New revision: 421887
URL: https://svnweb.freebsd.org/changeset/ports/421887

Log:
  MFH: r421533

  gecko: drop poorly maintained GIO=off case after r376999

  Glib IO is already used by Gtk internally, so there's little reason
  to avoid it unless using non-Gtk builds which are no longer supported.

  https://bugzilla.mozilla.org/show_bug.cgi?id=1286627
  https://bugzilla.mozilla.org/show_bug.cgi?id=1287288

  PR:		210220
  Reported by:	Marco Beishuizen, Arrigo Marchiori
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2016Q3/
  branches/2016Q3/Mk/bsd.gecko.mk
  branches/2016Q3/www/firefox/Makefile.options