Bug 210532 - sysutils/fusefs-encfs: Fix "Function not implemented" on create operations
Summary: sysutils/fusefs-encfs: Fix "Function not implemented" on create operations
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kurt Jaeger
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks: 210510
  Show dependency tree / graph
 
Reported: 2016-06-24 16:23 UTC by Dmitri Goutnik
Modified: 2016-06-27 05:48 UTC (History)
2 users (show)

See Also:
pi: merge-quarterly-

Attachments
patch (2.46 KB, patch)
2016-06-24 16:23 UTC, Dmitri Goutnik 		dmgk: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2016-06-24 16:23:36 UTC 
Created attachment 171759 [details]
patch

Fixes bug #210510

testport 10.3-RELEASE-p5 amd64: http://poudriere.syrec.org/fusefs-encfs/1.8.1_1/10amd64-default.log

testport 9.3-RELEASE-p44 amd64: http://poudriere.syrec.org/fusefs-encfs/1.8.1_1/9amd64-default.log
Comment 1 VK 2016-06-24 20:00:45 UTC 
Comment on attachment 171759 [details]
patch

Thanks for the patch. For the reference, this is the upstream commit that fixes it:

https://github.com/vgough/encfs/commit/aacce54f42add2e4560b53c9138835151c332362

Dmitri, a hint for your future valued contributions, please include a reference whether such patches have been pulled in from upstream or submitted to upstream. ;)

Also please flag your attachments with maintainer-approval(+) to help us track issues better through "Maintainer approved" saved search.
Comment 2 Dmitri Goutnik freebsd_committer freebsd_triage 2016-06-24 20:05:43 UTC 
Vladimir, the upstream patch that you referenced was already merged in when I inherited the sources. I just missed this line -

https://github.com/vgough/encfs/commit/aacce54f42add2e4560b53c9138835151c332362#diff-297b5a12227f435821a06a5bb43ea14dL608

when I redid patches in /files, that was the reason of "function not implemented" errors.
Comment 3 VK 2016-06-24 22:57:50 UTC 
Yes, but I found no reference even for the previous patch. With this the committers can quickly look it up and verify. Thing is, the guidelines on such patches is that they should be upstreamed or pulled in from upstream, to reduce the technical debt. ;)
Comment 4 Dmitri Goutnik freebsd_committer freebsd_triage 2016-06-24 22:59:26 UTC 
Understood, will do.
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2016-06-27 05:46:58 UTC 
Committed, thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-06-27 05:47:08 UTC 
A commit references this bug:

Author: pi
Date: Mon Jun 27 05:46:38 UTC 2016
New revision: 417634
URL: https://svnweb.freebsd.org/changeset/ports/417634

Log:
  sysutils/fusefs-encfs: Fix "Function not implemented" on create operations

  Upstream fix was:
    https://github.com/vgough/encfs/commit/aacce54f42add2e4560b53c9138835151c332362

  PR:		210532
  Submitted by:	Dmitri Goutnik <dg@syrec.org> (maintainer)

Changes:
  head/sysutils/fusefs-encfs/files/patch-encfs_encfs.cpp
  head/sysutils/fusefs-encfs/files/patch-encfs_main.cpp
  head/sysutils/fusefs-encfs/files/patch-encfs_makeKey.cpp
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-06-27 05:48:09 UTC 
A commit references this bug:

Author: pi
Date: Mon Jun 27 05:47:39 UTC 2016
New revision: 417635
URL: https://svnweb.freebsd.org/changeset/ports/417635

Log:
  sysutils/fusefs-encfs: Fix "Function not implemented" on create operations

  Upstream fix was:
    https://github.com/vgough/encfs/commit/aacce54f42add2e4560b53c9138835151c332362

  PR:           210532
  Submitted by: Dmitri Goutnik <dg@syrec.org> (maintainer)

Changes:
  head/sysutils/fusefs-encfs/Makefile