- Some of the committers on the page, e.g. attilio, no longer have commit privileges. - My chosen name is incorrect (correct per master.passwd on freefall, but not correct per other documentation..): """Hi John, I go by “Ngie” now instead of “Garrett” (even though my commits are still being done with my legal name – I haven’t been able to chase down the accounts@FreeBSD.org folks about it yet: https://svnweb.freebsd.org/doc?view=revision&revision=48838 // https://svnweb.freebsd.org/base?view=revision&revision=301869 :/ ). No big deal – just wanted to clarify . Thanks! -Ngie """ Noticed by: John Hayden <john.hayden@isilon.com>
Take, my plan is to update the current list of ports committers.
@Matthew, can you move attilio@ to the src alumni (so that I do not interfere with your work)? @Ngie, do you know if there are any references left or should I just grep the doc/ports/src trees?
(In reply to Rene Ladan from comment #2) I have about 20 commit bits to take in at the end of this month (ie. next Tuesday). I shall handle attilio's committer-emeritus entry alongside those. Please feel free to make whatever changes you want to the contributor pages in the mean time: it won't be any trouble for me.
I grepped the CURRENT src tree (r313154) and only found this one: /usr/src/include/mk-osreldate.sh:# Copyright (c) 2013 Garrett Cooper and some entries in contrib code but that is out of FreeBSD's scope.
So, after preparing my update taking account of the commit bits reaped in base commit r313029, I checked for people with commit bits not mentioned in docs/en_US.ISO8859-1/articles/contributors/contrib.committers: ``` $ for c in $( cat /tmp/all-committers ); do if ! grep -q $c contrib.committers.xml ; then echo $c fi done anne dexter dexuan jimharris murray n_hibma rpokala sephe ``` Of these anne, dexter, dexuan, rpokala don't have entries in docs/share/xml/authors.ent either Then there are these people in contrib.develalumni despite having an active commit bit: ``` $ for c in $( cat /tmp/all-committers ); do > if grep -qE "\<$c\>" contrib.develalumni.xml ; then > echo $c > fi > done murray pho ru sephe ``` murray -- docs pho -- base ru -- base sephe -- base
Bah! Now lets repeat the above, but this time correctly including all of the ports committers. People appearing in contrib.develalumni.xml, despite having an active commit bit: ``` $ for c in $( cat /tmp/all-committers ); do if grep -q "a.\<$c\>" contrib.develalumni.xml ; then echo $c fi done gordon krion murray pho ru sephe ``` gordon -- ports krion -- ports murray -- doc pho -- src ru -- src sephe -- src People with commit bits that do not appear in contrib.committers.xml: ``` $ for c in $( cat /tmp/all-committers ); do > if ! grep -q $c contrib.committers.xml ; then > echo $c > fi > done anne dexter dexuan jimharris krion murray n_hibma rpokala sephe ```
Actually, contrib.committers.xml contains lots of entries for people who have since given up their commit bits. Extract the list of uids from contrib.committers.xml ``` % perl -ne 'm/<para>&a\.([^\.]+)\./ && print "$1\n";' < contrib.committers.xml | sort > /tmp/contrib.committers ``` Then people appearing in contrib.committers.xml without an active commit bit are: ``` % comm -1 -3 /tmp/all-committers /tmp/contrib.committers ade ahze alexey attilio avl beech brix chinsan clement clsung davide dhn edwin erwin gj glarkin hq jase jmelo keramida kientzle lbr leeym lioux lippe matusita max mdf mezz milki mmoll mva nhibma rafan roam sahil scheidell sem skv sperber stefan sumikawa tmseck xmj yar yzlin ``` And people with an active commit bit not appearing in contrib.committers.xml: ``` % comm -2 -3 /tmp/all-committers /tmp/contrib.committers ale anne dexter dexuan jimharris krion murray n_hibma rpokala ru sephe ```
(In reply to Matthew Seaman from comment #5) "n_hibma" is a typo. It should be "nhibma"
Actually, contrib.committers.xml contains lots of entries for people who have since given up their commit bits. Extract the list of uids from contrib.committers.xml ``` % perl -ne 'm/<para>&a\.([^\.]+)\./ && print "$1\n";' < contrib.committers.xml | sort > /tmp/contrib.committers ``` Then people appearing in contrib.committers.xml without an active commit bit are: ``` % comm -1 -3 /tmp/all-committers /tmp/contrib.committers ade ahze alexey attilio avl beech brix chinsan clement clsung davide dhn edwin erwin gj glarkin hq jase jmelo keramida kientzle lbr leeym lioux lippe matusita max mdf mezz milki mmoll mva nhibma rafan roam sahil scheidell sem skv sperber stefan sumikawa tmseck xmj yar yzlin ``` And people with an active commit bit not appearing in contrib.committers.xml: ``` % comm -2 -3 /tmp/all-committers /tmp/contrib.committers anne dexter dexuan jimharris krion murray n_hibma rpokala ru sephe ```
(In reply to Ngie Cooper from comment #8) Hmmm.... 'n_hibma' is what is in src/svnadmin/conf/access: https://svnweb.freebsd.org/base/svnadmin/conf/access?revision=313029&view=markup#l149 and he is actively making src commits under that uid, and finger thinks his username is n_hibma: ``` freefall:~:% finger hibma Login: n_hibma Name: Nick Hibma Directory: /home/n_hibma Shell: /usr/local/bin/bash Last login Tue Nov 15 12:43 (UTC) on pts/19 from 2001:980:530a:1:1d98:de2a:4529:bad6 No Mail. Plan: I must have it here somewhere... Just a minute... You are not on a modem calling international, are you? ```
(In reply to Matthew Seaman from comment #10) Seems he's the exception to the rule that the entity names in docs/share/xml/authors.ent should be the same as the freefall login names.
A commit references this bug: Author: rene Date: Sat Feb 11 13:49:51 UTC 2017 New revision: 49967 URL: https://svnweb.freebsd.org/changeset/doc/49967 Log: gordon and krion had their ports bit reactivated, so comment them out from the developers alumni section. PR: 211021 (part) Submitted by: ngie Reported by: matthew (in comment #6) Changes: head/en_US.ISO8859-1/articles/contributors/contrib.develalumni.xml
A commit references this bug: Author: rene Date: Sat Feb 11 15:27:36 UTC 2017 New revision: 49968 URL: https://svnweb.freebsd.org/changeset/doc/49968 Log: Move former ports committers from the committers to the alumni list. PR: 211021 Submitted by: ngie Reported by: matthew (comment #7) Changes: head/en_US.ISO8859-1/articles/contributors/contrib.committers.xml head/en_US.ISO8859-1/articles/contributors/contrib.develalumni.xml
Is there any work left here?