Bug 211437 - net/mosh: fails to compile on 11.x+ (with a fix)
Summary: net/mosh: fails to compile on 11.x+ (with a fix)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Ryan Steinmetz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-29 08:20 UTC by Peter Wemm
Modified: 2016-07-30 12:46 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (zi)

Attachments
Fix crytpo/ocb.cc (377 bytes, patch)
2016-07-29 08:20 UTC, Peter Wemm 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Wemm freebsd_committer freebsd_triage 2016-07-29 08:20:16 UTC 
The most recent commit to net/mosh added a patch that tested autoconf results regarding bswap32/bswap64 etc.  However, it forgot to #include "config.h".

The other byte order sensitive code seems to #include "byteorder.h" which pulls in config.h.  To fix mosh I added #include "byteorder.h" to crypto/ocb.cc.

Patch included.
Comment 1 Peter Wemm freebsd_committer freebsd_triage 2016-07-29 08:20:51 UTC 
Created attachment 173088 [details]
Fix crytpo/ocb.cc
Comment 2 Ryan Steinmetz freebsd_committer freebsd_triage 2016-07-30 12:42:59 UTC 
Submitted upstream: https://github.com/mobile-shell/mosh/issues/783

Running build tests now.
Comment 3 Ryan Steinmetz freebsd_committer freebsd_triage 2016-07-30 12:45:44 UTC 
Committed revision 419315.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-07-30 12:46:04 UTC 
A commit references this bug:

Author: zi
Date: Sat Jul 30 12:45:32 UTC 2016
New revision: 419315
URL: https://svnweb.freebsd.org/changeset/ports/419315

Log:
  - Fix build under 11.x

  PR:		211437
  Submitted by:	peter@
  Sponsored by:	Maximum Effort

Changes:
  head/net/mosh/files/patch-ocb_cc