Bug 211682 - net/omnitty: Add abililty to "toggle" tagged machines
Summary: net/omnitty: Add abililty to "toggle" tagged machines
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-09 02:08 UTC by david
Modified: 2018-08-09 12:27 UTC (History)
3 users (show)

See Also:


Attachments
Patch containing declaration of machmgr_toggle_tag_all() function (535 bytes, patch)
2016-08-09 02:08 UTC, david
no flags Details | Diff
Patch containing machmgr_toggle_tag_all() function (367 bytes, patch)
2016-08-09 02:10 UTC, david
no flags Details | Diff
Patch containing code to invoke machmgr_toggle_tag_all() function (947 bytes, patch)
2016-08-09 02:11 UTC, david
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description david 2016-08-09 02:08:43 UTC
Created attachment 173429 [details]
Patch containing declaration of machmgr_toggle_tag_all() function

I use net/omnitty a fair bit, often with fairly large lists of machines.

I often need to do "something" to about half the machines, then do "something else" to the other half.  So I came up with a hack to toggle the "tagged" status of the machines.

This is implemented by means of the F1 menu; I added the command characters "o" and "O" for this purpose.  (I was going to use "x" and "X", but "X" is already in use.  If someone else has a better/more mnemonic code letters to use... well, I'm in favor!)

Anyway, drop the attached patchfiles into the files/ subdirectory, then make the port as usual.  I went ahead and separated the patchfiles, as I understand that it's traditional to have a separate patchfile for each port file that's being patched, even though they collectively implement a single function.
Comment 1 david 2016-08-09 02:10:25 UTC
Created attachment 173430 [details]
Patch containing machmgr_toggle_tag_all() function

I don't seem to be able to create a PR with multiple attachments. :-/
Comment 2 david 2016-08-09 02:11:13 UTC
Created attachment 173431 [details]
Patch containing code to invoke machmgr_toggle_tag_all() function
Comment 3 commit-hook freebsd_committer 2018-08-09 12:25:59 UTC
A commit references this bug:

Author: tobik
Date: Thu Aug  9 12:25:09 UTC 2018
New revision: 476742
URL: https://svnweb.freebsd.org/changeset/ports/476742

Log:
  net/omnitty: Add abililty to "toggle" tagged machines

  We often need to do "something" to about half the machines, then
  do "something else" to the other half.  So add a hack to toggle the
  "tagged" status of the machines.

  This is implemented by means of the F1 menu; the command characters
  "o" and "O" can toggle the "tagged" status of the machines.

  PR:		211682
  Submitted by:	maintainer

Changes:
  head/net/omnitty/Makefile
  head/net/omnitty/files/patch-machmgr.c
  head/net/omnitty/files/patch-machmgr.h
  head/net/omnitty/files/patch-main.c
  head/net/omnitty/files/patch-menu.c
Comment 4 Tobias Kortkamp freebsd_committer 2018-08-09 12:27:10 UTC
Finally committed. Thanks!

This was really annoying to apply.  Having to download and move
individual patch files is no fun.  I did this out of good will now
since the bug is already 2 years old, but please provide a single
diff generated with `svn diff` that we can apply against the port
with `svn patch` in the future.