Created attachment 174125 [details]
Revert problematic commit
A GCC 6 fix for swig causes the errors found here https://www.bayofrum.net/pkg/110amd64-system/2016-08-26_18h47m55s/logs/errors/znc-1.6.3_2.log
This patch reverts the commit.
Upstream issue; https://github.com/swig/swig/issues/615
Auto assign fail!
Thanks Chris, could you replace attachment 174125 [details] (contains a URL to bayofrum.net/~crees/patches) with the patch itself please.
There's a minor typo in the patch comment itself, "swigissues/615" (404) should be "swig/issues/615"
Also for whoever commits this, if you could include a reference to the upstream issue url in the commit log message, it will add a comment to the github issue, allowing users to see what happened downstream.
FWIW, I believe this change comes under blanket/implicit approval, not needing maintainer approval (if tested/QA'd).
It is tested, but only with znc/clang- Sunpoet may wish to test with other combinations, so this is a courtesy.
I'll upload the patch when I'm on a computer, not a tablet- that's the reason it didn't attach properly last time.
Created attachment 174653 [details]
Another patch variant
Here's another solution, it doesn't revert the commit, but addresses the problem (missing header) directly.
Upstream issue https://github.com/swig/swig/pull/788 (sorry, I haven't noticed there was an issue already).
While here, the patch
- Fixes lincese
- Removes obsolete REINPLACE (malloc.h is not in swig code for years)
- Silences stuff which should be silenced
Much better solution, thanks. We're actually past two weeks for timeout purposes anyway, so I think you should commit your fix if you know it fixes znc.
A commit references this bug:
Date: Sun Sep 11 17:40:43 UTC 2016
New revision: 421850
- Add missing include to generated code, fixing build of irc/znc
- Fix LICENSE and add LICENSE_FILE
- Remove long obsolete REINPLACE_CMD
- Silence patching and stipping
Upstream bugreport for reference: https://github.com/swig/swig/pull/788
Submitted by: crees, amdmi3
Approved by: maintainer timeout (sunpoet, 2 weeks)