Bug 212304 - security/rubygem-bcrypt: rip out unused crypt_r implementation
Summary: security/rubygem-bcrypt: rip out unused crypt_r implementation
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-01 10:22 UTC by Johannes Jost Meixner
Modified: 2016-09-07 18:41 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (ruby)


Attachments
rip crypt_r out of rubygem-bcrypt (1.32 KB, patch)
2016-09-01 10:22 UTC, Johannes Jost Meixner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Jost Meixner freebsd_committer 2016-09-01 10:22:36 UTC
Created attachment 174283 [details]
rip crypt_r out of rubygem-bcrypt

In r303920 [1] ed@ added a thread-safe implementation of crypt, crypt_r(3).

This change breaks rubygem-bcrypt on 12.0-CURRENT.

As the crypt_r implementation found in the gem isn't used one way or another, rip it out, and unbreak the package build on 12.0-CURRENT
Comment 1 Ben Woods freebsd_committer 2016-09-07 03:58:47 UTC
For details of the symptoms of this bug, please see the following mailing list post:
https://lists.freebsd.org/pipermail/freebsd-ruby/2016-September/006675.html
Comment 2 commit-hook freebsd_committer 2016-09-07 18:38:18 UTC
A commit references this bug:

Author: swills
Date: Wed Sep  7 18:37:35 UTC 2016
New revision: 421517
URL: https://svnweb.freebsd.org/changeset/ports/421517

Log:
  security/rubygem-bcrypt: rip out unused crypt_r implementation

  PR:		212304
  Submitted by:	xmj

Changes:
  head/security/rubygem-bcrypt/files/
  head/security/rubygem-bcrypt/files/patch-ext_mri_ow-crypt.h
  head/security/rubygem-bcrypt/files/patch-ext_mri_wrapper.c
Comment 3 Steve Wills freebsd_committer 2016-09-07 18:41:47 UTC
Committed, thanks!